New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow mounting into express.js application #36
Comments
Plus 1 for this ticket |
I think PeerServer should extend restify object to enable this feature (instead of keeping it in |
After some searching around - turns out, that restify can't be used with express. |
@floatdrop there is express-resource which should allow doing similar things as restify with Express |
@bergie yes, there is. I would write a pull-request to migrate from restify to express, but I don't know about repo owners thoughts on it. |
I'm very positive on moving from restify to express! |
PeerServer is now instance of express application - this allows to combine it with other express applications. Listen is deferred - because it now method from express (you can call it later and supply callback for start event). Constructor now not using `new` (because we mixing in methods to express app) Closes peers#36
As I mentioned in a separate thread, we actually switched FROM express to Michelle On Thu, Apr 3, 2014 at 7:27 AM, Fabian Becker notifications@github.comwrote:
|
Any progress on this? |
Looking forward for this too ! |
Can't wait 👍 |
Sorry for the delay on this--I'll try to get out an expressjs peer server this weekend. |
To fix request.query for expressjs I use this express workaround: expressApp.use(function(req, res, next){
req.query = null;
next();
}) the middlware should be first in express. |
Hi, how's it going with migration? |
The PeerJS server is definitely a nice piece of software, but it would be great if it could be mounted into an existing express.js application. This would allow people to build more advanced applications around the server.
The text was updated successfully, but these errors were encountered: