Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US-620855 Add detemplatize executable using multi stage docker build #217

Merged
merged 11 commits into from
Jul 1, 2024

Conversation

akshithac-21
Copy link
Contributor

@akshithac-21 akshithac-21 commented Jun 24, 2024

Using detemplatize image as multi stage docker build, to avoid writing custom code to copy detemplatize library for building images with different OS and JDK.

@akshithac-21 akshithac-21 requested review from dcasavant and a team as code owners June 24, 2024 13:47
@Saurabh-16
Copy link
Contributor

@akshithac-21 With this change, we should be good to update this readme https://github.com/pegasystems/docker-pega-web-ready/blob/master/docs/Building-Image-With-Own-OS-And-JDK.md to remove the instructions to copy the detemplatize executable.

@kingakowalska1
Copy link

Hi,

I think we can safely combine lines 11 and 13 and shorten the first step to:

  1. Create a Dockerfile for your custom pega-web-ready image using your base image and the open-source pega-web-ready Dockerfile code.

The rest looks great!

Thanks,
Kinga

Copy link

@kingakowalska1 kingakowalska1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MadhuriArugula MadhuriArugula merged commit b323f5e into pegasystems:master Jul 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants