Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version floor conflict #100

Closed
StoneCypher opened this issue Apr 22, 2021 · 9 comments
Closed

Version floor conflict #100

StoneCypher opened this issue Apr 22, 2021 · 9 comments

Comments

@StoneCypher
Copy link
Contributor

Two libraries we've added - babel and nve - require core-js.

Core-js has a node floor of 12, but we offer a node floor of 10. As a result, our node 10 builds are breaking.

We are already getting rid of nve, and I think we're considering switching from babel to typescript for downcompiling

May I temporarily remove the 10.x claim from the build, with the goal of re-adding it once babel is out?

image

@hildjj
Copy link
Contributor

hildjj commented Apr 22, 2021

nve is removed in #89

@hildjj
Copy link
Contributor

hildjj commented Apr 22, 2021

yes, you can update to >=12, with the idea that we won't release anything where that lands until 2021-05-01 or later.

@StoneCypher
Copy link
Contributor Author

nve is removed in #89

It's still in package-lock. I'll fix it

image

@StoneCypher
Copy link
Contributor Author

yes, you can update to >=12, with the idea that we won't release anything where that lands until 2021-05-01 or later.

I mean, honestly, I still kind of want to support 10

I just want to reduce the claim for a couple days while I get the underlying breakage fixed

@hildjj
Copy link
Contributor

hildjj commented Apr 22, 2021

gah, sorry I missed updating package-lock. fixing it in my PR.

@StoneCypher
Copy link
Contributor Author

forgetting package-lock is the second most common mistake i make in node, behind forgetting to rebuild before pushing 😂

@hildjj
Copy link
Contributor

hildjj commented Apr 22, 2021

Hm. I just regenerated package-lock from scratch, git diff doesn't show a change. Maybe I got this in the latest rebase I just pushed?

@StoneCypher
Copy link
Contributor Author

easiest way to check is probably cat package-lock.json | grep core-js

@hildjj
Copy link
Contributor

hildjj commented Apr 22, 2021

        "core-js-compat": "^3.9.0",
        "core-js-compat": "^3.9.1"
    "node_modules/core-js-compat": {
      "resolved": "https://registry.npmjs.org/core-js-compat/-/core-js-compat-3.10.2.tgz",
        "url": "https://opencollective.com/core-js"
    "node_modules/core-js-compat/node_modules/semver": {
        "core-js-compat": "^3.9.0",
        "core-js-compat": "^3.9.1"
    "core-js-compat": {
      "resolved": "https://registry.npmjs.org/core-js-compat/-/core-js-compat-3.10.2.tgz",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants