-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version floor conflict #100
Comments
nve is removed in #89 |
yes, you can update to >=12, with the idea that we won't release anything where that lands until 2021-05-01 or later. |
It's still in |
I mean, honestly, I still kind of want to support 10 I just want to reduce the claim for a couple days while I get the underlying breakage fixed |
gah, sorry I missed updating package-lock. fixing it in my PR. |
forgetting package-lock is the second most common mistake i make in node, behind forgetting to rebuild before pushing 😂 |
Hm. I just regenerated package-lock from scratch, git diff doesn't show a change. Maybe I got this in the latest rebase I just pushed? |
easiest way to check is probably |
|
Two libraries we've added - babel and nve - require core-js.
Core-js has a node floor of 12, but we offer a node floor of 10. As a result, our node 10 builds are breaking.
We are already getting rid of
nve
, and I think we're considering switching frombabel
totypescript
for downcompilingMay I temporarily remove the 10.x claim from the build, with the goal of re-adding it once babel is out?
The text was updated successfully, but these errors were encountered: