Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template issue when using Swift setup #48

Open
1 of 2 tasks
ma-pe opened this issue Feb 18, 2018 · 4 comments
Open
1 of 2 tasks

Template issue when using Swift setup #48

ma-pe opened this issue Feb 18, 2018 · 4 comments
Labels

Comments

@ma-pe
Copy link

ma-pe commented Feb 18, 2018

Dev setup:

  • react-native-create-bridge version: 1.2.0
  • react-native version: 0.53.0

I am using create-bridge in a:

  • standalone library
  • existing React Native project

What you did:

Setup a new Native Module & UI Component in Swift.

What happened:

ModuleName.m
RCT_EXPORT_VIEW_PROPERTY("exampleProp", NSString) should be RCT_EXPORT_VIEW_PROPERTY(exampleProp, NSString)

@ma-pe
Copy link
Author

ma-pe commented Feb 18, 2018

There are multiple compiler errors for ModuleName.swift when importing, too.

@ma-pe
Copy link
Author

ma-pe commented Feb 18, 2018

Fewer and different errors though, if you just use the Native Module setup for swift (without UI Module).

@jarretmoses
Copy link
Collaborator

@ma-pe thanks for reporting this. I will need a little time to investigate this myself. However, feel free to open a PR with your suggested changes and I will gladly review it.

@jarretmoses jarretmoses added the bug label Mar 2, 2018
@paul019
Copy link

paul019 commented Oct 19, 2018

@ma-pe I have the same issue. Like you suggested, I have changed RCT_EXPORT_VIEW_PROPERTY("exampleProp", NSString) to RCT_EXPORT_VIEW_PROPERTY(exampleProp, NSString). Nevertheless, there is still the same error: Value of type 'ModuleName' has no member 'exampleProp'. Do you have any idea how to solve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants