Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop IE8 support and update code accordingly #441

Closed
6 tasks done
dmajda opened this issue Aug 25, 2016 · 1 comment
Closed
6 tasks done

Drop IE8 support and update code accordingly #441

dmajda opened this issue Aug 25, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@dmajda
Copy link
Contributor

dmajda commented Aug 25, 2016

IE8 is obsolete and its support can be dropped (see the Twitter poll). This allows us to modernize the code a bit.

Tasks:

  • Replace arrays.map & friends with native methods
  • Replace objects.keys & friends with native methods
  • Replace ... instanceof Array with Array.isArray(...)
  • Replace suitable for loops with Array methods
  • Remove undefined redefinition protection
  • Remove various IE8 hacks
@dmajda dmajda added the task label Aug 25, 2016
@dmajda dmajda added this to the 0.11.0 milestone Aug 25, 2016
@dmajda dmajda self-assigned this Aug 28, 2016
dmajda added a commit that referenced this issue Sep 1, 2016
dmajda added a commit that referenced this issue Sep 1, 2016
dmajda added a commit that referenced this issue Sep 1, 2016
dmajda added a commit that referenced this issue Sep 1, 2016
dmajda added a commit that referenced this issue Sep 1, 2016
dmajda added a commit that referenced this issue Sep 1, 2016
dmajda added a commit that referenced this issue Sep 1, 2016
@dmajda
Copy link
Contributor Author

dmajda commented Sep 1, 2016

This is done now.

Note some (if not all) features mentioned in the description and used in the code now are available only in IE standards mode, not quirks mode. This means PEG.js does not support IE quirks mode from now on.

@dmajda dmajda closed this as completed Sep 1, 2016
dmajda added a commit that referenced this issue Dec 8, 2016
Should have been done as part of #441.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant