Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #9: Add testes with |trace| option set to |true|. #397

Closed
wants to merge 1 commit into from

Conversation

Mingun
Copy link
Contributor

@Mingun Mingun commented Jan 9, 2016

You forgot to add them. When I wrote one of the my passes, the generator broke in case of trace option on. Now such errors will be caught by tests.

dmajda added a commit that referenced this pull request Aug 1, 2016
@dmajda
Copy link
Contributor

dmajda commented Aug 1, 2016

I agree that the options.trace == true case was missing, thanks for pointing it out.

Applying this PR as it is (after resolving the conflict) causes clutter in test output because the default tracer uses console.log. I decided to stub out console.log using Jasmine’s spyOn and I committed the improved solution with a pointer to this PR.

@dmajda dmajda closed this Aug 1, 2016
@Mingun Mingun deleted the add-trace-tests branch August 1, 2016 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants