Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the appName from the connection option object to the login payload constructor #91

Closed
mburbea opened this issue Mar 26, 2013 · 1 comment
Closed

Pass the appName from the connection option object to the login payload constructor #91

mburbea opened this issue Mar 26, 2013 · 1 comment

Comments

@mburbea
Copy link

mburbea commented Mar 26, 2013

https://github.com/pekim/tedious/blob/master/src/connection.coffee#L388
The call to the payload constructor is never assigned an appName attribute.
This means that when a trace is run all traffic from an application using tedious comes in with an application name of Tedious. It should be fairly simple fix.
Thanks and great work!
@pekim pekim closed this as completed in fbdb764 Mar 27, 2013
@pekim
Copy link
Collaborator

pekim commented Mar 27, 2013

I haven't added an integration test for this, but I've tested it manually with examples/simple-client.js.
sp_who2 shows that if appName is supplied in config options it is now used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pekim @mburbea