Problem with date storage #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this explain issue #95? |
|
Yeah I think so. I was seeing similar problems on my end. Btw just noticed the tests failed I'll get on fixing them |
|
Glade you had some tests around this. When looking at the test I realized that I didn't account for the difference in tds and js epoch. Everything should be working now. |
|
Also I noticed that when datetime is being written that it was using a UInt for days when it should just use Int. I believe pull request #106 fixed part of this. Looks like small date should both be UInt though. |
zero length varchar params don't work unless a length greater than zero ...
patriksimek
added a commit
that referenced
this pull request
Mar 10, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue that the date stored in the database wasn't being stored as UTC. I've changed all date methods to reference the UTC value. It might be worth mentioning that getTime/setTime are UTC relative methods while all else are timezone relative unless otherwise specified.
Since this might break everyone that has used tedious before it might be beneficial to make this type of conversion to be a configuration setting. What do you think?