Using connection timeout for SQL Browser lookup #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the usage of the connection timeout option for doing SQL Server Browser look-ups; currently, it's only possible to use the default timeout of 2 seconds.
|
+1 |
|
This is great, thanks! Will roll this in to the next release (v1.5.3) |
|
Yeah, looks good to me as well. |
rossipedia
added a commit
that referenced
this pull request
Sep 26, 2014
…ut-pr Using connection timeout for SQL Browser lookup
|
Although now that I think about it, this will make it |
DullReferenceException
pushed a commit
to DullReferenceException/node-mssql
that referenced
this pull request
Oct 7, 2014
SQL Browser operations in `tedious` had a hard-coded 2 second timeout. Now that it's fixed (see tediousjs/tedious#196) and released as `v1.5.3`, I'd like to pull it into `mssql`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the usage of the connection timeout option for doing SQL Server Browser look-ups; currently, it's only possible to use the default timeout of 2 seconds.
This is for Issue #195