New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coarse_reverse): add try/catch block around synthesizeDoc code #1003

Merged
merged 2 commits into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@missinglink
Member

missinglink commented Sep 25, 2017

fix for the pagerduty alert reported this morning:

2017-09-25_08:03:40.45896 /srv/www/api/releases/20170919173917/node_modules/pelias-model/util/valid.js:29
2017-09-25_08:03:40.45896     throw new PeliasModelError( 'invalid document type, expecting: truthy, got: ' + val );
2017-09-25_08:03:40.45896     ^
2017-09-25_08:03:40.45934 PeliasModelError: invalid document type, expecting: truthy, got: 
2017-09-25_08:03:40.45934     at Object.module.exports.truthy (/srv/www/api/releases/20170919173917/node_modules/pelias-model/util/valid.js:29:11)
2017-09-25_08:03:40.45934     at Document.<anonymous> (/srv/www/api/releases/20170919173917/node_modules/pelias-model/Document.js:255:14)
2017-09-25_08:03:40.45935     at Document.addParent (/srv/www/api/releases/20170919173917/node_modules/pelias-model/Document.js:291:5)
2017-09-25_08:03:40.45935     at /srv/www/api/releases/20170919173917/controller/coarse_reverse.js:70:9
2017-09-25_08:03:40.45935     at Array.forEach (native)
2017-09-25_08:03:40.45935     at synthesizeDoc (/srv/www/api/releases/20170919173917/controller/coarse_reverse.js:69:19)
2017-09-25_08:03:40.45936     at /srv/www/api/releases/20170919173917/controller/coarse_reverse.js:144:23
2017-09-25_08:03:40.45936     at /srv/www/api/releases/20170919173917/node_modules/pelias-microservice-wrapper/service.js:110:18
2017-09-25_08:03:40.45936     at Request.callback (/srv/www/api/releases/20170919173917/node_modules/superagent/lib/node/index.js:679:14)
2017-09-25_08:03:40.45936     at /srv/www/api/releases/20170919173917/node_modules/superagent/lib/node/index.js:868:18
2017-09-25_08:03:41.04725 loading libpostal data, this may take a few seconds...
@orangejulius

Looks good. nice logging

@missinglink missinglink merged commit 187a998 into master Sep 25, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment