-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzziness #41
Conversation
…ueries (because that results in an overkill) (this is a test)
…roller. Adding sort_by_score
Conflicts: controller/suggest.js
oh yeah, this is good to go. I left it open for you to review/merge it. |
looks good, I'll pull and test locally, two comments:
it's a bit annoying that we have to maintain 2 suggesters but I still think
I am struggling to figure out what's going on in there, is there some way we can re-factor out the individual components so they can be re-used and tested independently? |
fair point. This is why I like code reviews 😄
I agree that We could close this PR without merging and I can work on a refactor? |
Conflicts: test/unit/controller/suggest.js test/unit/helper/geojsonify.js
…queryMizer.json, deleting controller/suggest_nearby.js and test/unit/controller/suggest_naerby.js (because suggest_nearby is like suggest with a different query-mix. disabling a test in suggest.js for the moment
closing this in favor of #59 |
This implements fuzzy suggest - you can now actually have a typo in your search term and the right result will show up. The fuzziness factor is set to AUTO
because it generates an edit distance based on the length of the term. For lengths:
0..1 - must match exactly
1..4 - one edit allowed
">4"- two edits allowed