Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search with optional bbox #60

Merged
merged 7 commits into from
Jan 19, 2015
Merged

search with optional bbox #60

merged 7 commits into from
Jan 19, 2015

Conversation

hkrishna
Copy link
Contributor

[DO NOT MERGE YET] - depends on geopipes/elasticsearch-backend#3
initial commit + tests

@missinglink
Copy link
Member

LGTM, ditto on geopipes/elasticsearch-backend#3 (comment)

If we enable this by default then bbox will be required for all searches, do we want to do that or fall back to the 50km radius search when bbox is not available?

@hkrishna
Copy link
Contributor Author

I personally like the idea of it being optional. I can think of use-cases where you want to search within a bbox and when you want to find places closest to a lat/lon.

So, doing a 50km radius search if no bbox is passed in makes perfect sense to me - we just need to document it well.

hkrishna added a commit that referenced this pull request Jan 19, 2015
@hkrishna hkrishna merged commit 772ec68 into master Jan 19, 2015
@hkrishna hkrishna deleted the search-bbox branch January 19, 2015 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants