Adjust autocomplete focus boost #729

Merged
merged 1 commit into from Jan 4, 2017

Conversation

Projects
None yet
3 participants
@orangejulius
Member

orangejulius commented Nov 17, 2016

This lowers the autocomplete focus boost from 40 to 15. The idea is
that, because the boost for population is 20, the focus can't possibly
override a popular city, but it can come close.

On our default dev build, no acceptance tests fail but the san francisco
autocomplete test now passes!

It's not clear if this fixes WOF venue issues yet, since the latest
build there failed, so stay tuned :(

@orangejulius orangejulius added this to the WOF Venues milestone Nov 17, 2016

@orangejulius orangejulius self-assigned this Nov 17, 2016

@trescube

Seems like a reasonable value if it doesn't break any tests and fixes others.

@dianashk dianashk removed the in progress label Nov 17, 2016

Adjust autocomplete focus boost
This lowers the autocomplete focus boost from 40 to 15. The idea is
that, because the boost for population is 20, the focus can't possibly
override a popular city, but it can come close.

On our default dev build, no acceptance tests fail but the san francisco
autocomplete test now passes!

It's not clear if this fixes WOF venue issues yet, since the latest
build there failed :(
@orangejulius

This comment has been minimized.

Show comment
Hide comment
@orangejulius

orangejulius Jan 4, 2017

Member

There are more tweaks on deck on my machine that help with WOF venue things, but these changes are also good (and we can always tweak them later). I'd prefer to merge the WOF venue compatible changes along with this change, but since there are some other high priority things to do that may block that, and this is ready to go, we'll just merge it as is.

Member

orangejulius commented Jan 4, 2017

There are more tweaks on deck on my machine that help with WOF venue things, but these changes are also good (and we can always tweak them later). I'd prefer to merge the WOF venue compatible changes along with this change, but since there are some other high priority things to do that may block that, and this is ready to go, we'll just merge it as is.

@orangejulius orangejulius merged commit 60d52b1 into master Jan 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@orangejulius orangejulius removed the in review label Jan 4, 2017

@orangejulius orangejulius deleted the adjust_autocomplete_focus_boost branch Jan 6, 2017

@orangejulius orangejulius referenced this pull request in pelias/pelias Jan 11, 2017

Open

regression: "New York, NY" with focus point #330

orangejulius added a commit to pelias/acceptance-tests that referenced this pull request Feb 28, 2017

Mark SF focus test passing
This was fixed with pelias/api#729 some time
ago.

@orangejulius orangejulius referenced this pull request in pelias/acceptance-tests Feb 28, 2017

Merged

Mark SF focus test passing #350

je-l pushed a commit to nlsfi/pelias-api that referenced this pull request Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment