feat(client): Remove use of singleton pattern #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The singleton pattern has fallen out of favor lately, as it reduces the flexibility of a module, and sometimes makes it harder to unit test. More details on the singleton pattern: https://stackoverflow.com/questions/12755539/why-is-singleton-considered-an-anti-pattern This change removes dbclient's use of the singleton pattern, which should help folk who are using the module in ways we didn't anticipate. Fixes #77
orangejulius
force-pushed
the
remove-singleton
branch
from
bd9b53c
to
73d692d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The singleton pattern has fallen out of favor lately, as it reduces the flexibility of a module, and sometimes makes it harder to unit test.
More details on the singleton pattern: https://stackoverflow.com/questions/12755539/why-is-singleton-considered-an-anti-pattern
This change removes dbclient's use of the singleton pattern, which should help folk who are using the module in ways we didn't anticipate.
Fixes #77