improved logging of batch indexing errors #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
changed the title
|
|
||
| // additional debugging output of the error and corresponding request | ||
| var req = batch._slots.filter(s => _.get(s, 'cmd.index._id') === action._id); | ||
| logger.info(JSON.stringify(action, null, 2)); |
There was a problem hiding this comment.
what about the warn level? That implies the output is related to a problem much more than info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today I was debugging a batch indexing error and wasn't able to get enough information about the request in order to reproduce it.
this PR adds additional logging under the
infolog level which provides extended info about the error message and the original request.I chose
infobecause there is a lot going on inverboseso I wanted something between that anderror(andinfois the only option).Also added
lodashso I could use_.get()for safety reasons.