es8 support #518
Merged
es8 support #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
force-pushed
the
remove_type
branch
from
19f08a8
to
4ca7b53
Compare
missinglink
commented
Mar 13, 2024
| @@ -12,6 +12,7 @@ module.exports = Joi.object().keys({ | |||
| dataHost: Joi.string(), | |||
| s3Options: Joi.string(), | |||
| adminLookup: Joi.boolean(), | |||
| token: Joi.string(), | |||
There was a problem hiding this comment.
This change is actually unrelated but should exist since pelias/config#137
|
This is the final image compatible with elasticsearch v6: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR modifies the importer such that it works for both elasticsearch v7 & v8
in order to support v8 this PR drops support for v6.