Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support addr:place #515

Open
RicoElectrico opened this issue Mar 2, 2017 · 1 comment
Open

Support addr:place #515

RicoElectrico opened this issue Mar 2, 2017 · 1 comment
Labels
feature help wanted

Comments

@RicoElectrico
Copy link

RicoElectrico commented Mar 2, 2017 •
edited by dianashk
Loading

Hey team!

I was using your awesome geocoding engine when I noticed something interesting.
Let me tell you more about it.

Here's what I did 😇

https://search.mapzen.com/v1/search?text=tuchlinek%2085

Here's what I got 🙀

{
  "geocoding": {
    "version": "0.2",
    "attribution": "https://search.mapzen.com/v1/attribution",
    "query": {
      "text": "tuchlinek 85",
      "size": 10,
      "private": false,
      "querySize": 20
    },
    "engine": {
      "name": "Pelias",
      "author": "Mapzen",
      "version": "1.0"
    },
    "timestamp": 1488492906148
  },
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          -1.222086,
          44.056018
        ]
      },
      "properties": {
        "id": "polyline:8191435",
        "gid": "openstreetmap:street:polyline:8191435",
        "layer": "street",
        "source": "openstreetmap",
        "source_id": "polyline:8191435",
        "name": "85, 86, 91, 92",
        "street": "85, 86, 91, 92",
        "confidence": 0.74,
        "accuracy": "centroid",
        "country": "France",
        "country_gid": "whosonfirst:country:85633147",
        "country_a": "FRA",
        "macroregion": "Aquitaine",
        "macroregion_gid": "whosonfirst:macroregion:404227433",
        "region": "Landes",
        "region_gid": "whosonfirst:region:85683183",
        "macrocounty": "Dax",
        "macrocounty_gid": "whosonfirst:macrocounty:404227673",
        "county": "Castets",
        "county_gid": "whosonfirst:county:102064657",
        "localadmin": "Saint-Julien-En-Born",
        "localadmin_gid": "whosonfirst:localadmin:404349573",
        "label": "85, 86, 91, 92, Saint-Julien-En-Born, France"
      },
      "bbox": [
        -1.222206,
        44.055912,
        -1.221911,
        44.056076
      ]
    },
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          45.400356,
          35.593782
        ]
      },
      "properties": {
        "id": "polyline:13461960",
        "gid": "openstreetmap:street:polyline:13461960",
        "layer": "street",
        "source": "openstreetmap",
        "source_id": "polyline:13461960",
        "name": "156-85",
        "street": "156-85",
        "confidence": 0.74,
        "accuracy": "centroid",
        "country": "Iraq",
        "country_gid": "whosonfirst:country:85632191",
        "country_a": "IRQ",
        "region": "As-Sulaymaniyah",
        "region_gid": "whosonfirst:region:85672475",
        "county": "Sulaymaniya",
        "county_gid": "whosonfirst:county:1108562761",
        "label": "156-85, Iraq"
      },
      "bbox": [
        45.400138,
        35.593513,
        45.400573,
        35.594051
      ]
    },
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          35.491388,
          33.885857
        ]
      },
      "properties": {
        "id": "polyline:14312786",
        "gid": "openstreetmap:street:polyline:14312786",
        "layer": "street",
        "source": "openstreetmap",
        "source_id": "polyline:14312786",
        "name": "85",
        "street": "85",
        "confidence": 0.74,
        "accuracy": "centroid",
        "country": "Lebanon",
        "country_gid": "whosonfirst:country:85632533",
        "country_a": "LBN",
        "region": "Beirut",
        "region_gid": "whosonfirst:region:85673487",
        "county": "Beirut",
        "county_gid": "whosonfirst:county:1108691413",
        "label": "85, Lebanon"
      },
      "bbox": [
        35.491161,
        33.885826,
        35.491615,
        33.885887
      ]
    },
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          47.358707,
          45.408003
        ]
      },
      "properties": {
        "id": "polyline:20249167",
        "gid": "openstreetmap:street:polyline:20249167",
        "layer": "street",
        "source": "openstreetmap",
        "source_id": "polyline:20249167",
        "name": "85К-11",
        "street": "85К-11",
        "confidence": 0.74,
        "accuracy": "centroid",
        "region": "Республика Калмыкия",
        "region_gid": "whosonfirst:region:85687953",
        "county": "Laganskij",
        "county_gid": "whosonfirst:county:1108734883",
        "label": "85К-11"
      },
      "bbox": [
        47.358695,
        45.407566,
        47.365337,
        45.432514
      ]
    },
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          5.446931,
          46.094867
        ]
      },
      "properties": {
        "id": "polyline:20199910",
        "gid": "openstreetmap:street:polyline:20199910",
        "layer": "street",
        "source": "openstreetmap",
        "source_id": "polyline:20199910",
        "name": "D 85a",
        "street": "D 85a",
        "confidence": 0.74,
        "accuracy": "centroid",
        "country": "France",
        "country_gid": "whosonfirst:country:85633147",
        "country_a": "FRA",
        "macroregion": "Rhône-Alpes",
        "macroregion_gid": "whosonfirst:macroregion:404227439",
        "region": "Ain",
        "region_gid": "whosonfirst:region:85683153",
        "macrocounty": "Nantua",
        "macrocounty_gid": "whosonfirst:macrocounty:404228195",
        "county": "Poncin",
        "county_gid": "whosonfirst:county:102068853",
        "localadmin": "Saint-Alban",
        "localadmin_gid": "whosonfirst:localadmin:404387215",
        "label": "D 85a, Saint-Alban, France"
      },
      "bbox": [
        5.445382,
        46.093914,
        5.448628,
        46.095699
      ]
    },
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          5.533008,
          46.212662
        ]
      },
      "properties": {
        "id": "polyline:20199997",
        "gid": "openstreetmap:street:polyline:20199997",
        "layer": "street",
        "source": "openstreetmap",
        "source_id": "polyline:20199997",
        "name": "D 85",
        "street": "D 85",
        "confidence": 0.74,
        "accuracy": "centroid",
        "country": "France",
        "country_gid": "whosonfirst:country:85633147",
        "country_a": "FRA",
        "macroregion": "Rhône-Alpes",
        "macroregion_gid": "whosonfirst:macroregion:404227439",
        "region": "Ain",
        "region_gid": "whosonfirst:region:85683153",
        "macrocounty": "Nantua",
        "macrocounty_gid": "whosonfirst:macrocounty:404228195",
        "county": "Izernore",
        "county_gid": "whosonfirst:county:102067337",
        "localadmin": "Izernore",
        "localadmin_gid": "whosonfirst:localadmin:404391705",
        "label": "D 85, Izernore, France"
      },
      "bbox": [
        5.514173,
        46.188121,
        5.535367,
        46.216598
      ]
    },
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          10.7945,
          51.837337
        ]
      },
      "properties": {
        "id": "polyline:19618616",
        "gid": "openstreetmap:street:polyline:19618616",
        "layer": "street",
        "source": "openstreetmap",
        "source_id": "polyline:19618616",
        "name": "L 85",
        "street": "L 85",
        "confidence": 0.74,
        "accuracy": "centroid",
        "country": "Germany",
        "country_gid": "whosonfirst:country:85633111",
        "country_a": "DEU",
        "region": "Sachsen-Anhalt",
        "region_gid": "whosonfirst:region:85682519",
        "county": "Harz",
        "county_gid": "whosonfirst:county:102063857",
        "locality": "Wernigerode",
        "locality_gid": "whosonfirst:locality:101820907",
        "label": "L 85, Wernigerode, Germany"
      },
      "bbox": [
        10.794257,
        51.837219,
        10.79451,
        51.837379
      ]
    },
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          -57.917407,
          -34.944074
        ]
      },
      "properties": {
        "id": "node:3075289666",
        "gid": "openstreetmap:venue:node:3075289666",
        "layer": "venue",
        "source": "openstreetmap",
        "source_id": "node:3075289666",
        "name": "10 y 85",
        "confidence": 0.74,
        "accuracy": "point",
        "country": "Argentina",
        "country_gid": "whosonfirst:country:85632505",
        "country_a": "ARG",
        "region": "Buenos Aires",
        "region_gid": "whosonfirst:region:85668015",
        "county": "La Plata",
        "county_gid": "whosonfirst:county:1108717993",
        "label": "10 y 85, Argentina"
      }
    },
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          0.558533,
          48.015937
        ]
      },
      "properties": {
        "id": "polyline:20034987",
        "gid": "openstreetmap:street:polyline:20034987",
        "layer": "street",
        "source": "openstreetmap",
        "source_id": "polyline:20034987",
        "name": "D 85",
        "street": "D 85",
        "confidence": 0.74,
        "accuracy": "centroid",
        "country": "France",
        "country_gid": "whosonfirst:country:85633147",
        "country_a": "FRA",
        "macroregion": "Pays De La Loire",
        "macroregion_gid": "whosonfirst:macroregion:404227423",
        "region": "Sarthe",
        "region_gid": "whosonfirst:region:85683279",
        "macrocounty": "Mamers",
        "macrocounty_gid": "whosonfirst:macrocounty:404227957",
        "county": "Bouloire",
        "county_gid": "whosonfirst:county:102064943",
        "localadmin": "Saint-Michel-De-Chavaignes",
        "localadmin_gid": "whosonfirst:localadmin:404403991",
        "label": "D 85, Saint-Michel-De-Chavaignes, France"
      },
      "bbox": [
        0.550737,
        48.015933,
        0.565792,
        48.018634
      ]
    },
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          4.386112,
          43.486466
        ]
      },
      "properties": {
        "id": "polyline:20485357",
        "gid": "openstreetmap:street:polyline:20485357",
        "layer": "street",
        "source": "openstreetmap",
        "source_id": "polyline:20485357",
        "name": "D 85",
        "street": "D 85",
        "confidence": 0.74,
        "accuracy": "centroid",
        "country": "France",
        "country_gid": "whosonfirst:country:85633147",
        "country_a": "FRA",
        "macroregion": "Provence-Alpes-Côte D'Azur",
        "macroregion_gid": "whosonfirst:macroregion:404227445",
        "region": "Bouches-du-Rhône",
        "region_gid": "whosonfirst:region:85683441",
        "macrocounty": "Arles",
        "macrocounty_gid": "whosonfirst:macrocounty:404227823",
        "county": "Saintes-Maries-De-La-Mer",
        "county_gid": "whosonfirst:county:102069815",
        "label": "D 85, France"
      },
      "bbox": [
        4.384376,
        43.486408,
        4.386188,
        43.48653
      ]
    }
  ],
  "bbox": [
    -57.917407,
    -34.944074,
    47.365337,
    51.837379
  ]
}

Here's what I was expecting ✨

https://www.openstreetmap.org/search?query=tuchlinek%2085#map=19/54.31067/17.89585

Here's what I think could be improved 🏆

Add support for addr:place. This is not an "exotic" tag, in fact it has over 6M uses - in villages without street names.
@dianashk
Copy link
Contributor

dianashk commented Mar 7, 2017

Hey @RicoElectrico! 👋 Thanks for your feedback. This is actually really helpful for us! We didn't realize how many addresses are impacted by this.

We will need to investigate as a team the best approach for adding this feature and update this ticket with more details. If this is a very urgent requirement and you would like to collaborate on this issue with us, we'd be thrilled to accept a pull request! 😍

@orangejulius orangejulius mentioned this issue Mar 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RicoElectrico @dianashk