Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No results available for given street/city combination #67

Closed
ecgreb opened this issue Mar 26, 2015 · 14 comments
Closed

No results available for given street/city combination #67

ecgreb opened this issue Mar 26, 2015 · 14 comments
Assignees

Comments

@ecgreb
Copy link

ecgreb commented Mar 26, 2015

When searching for "203 Union Street Doylestown PA" no results are found for Union Street in Doylestown. Results are available for Union Street in other cities, and results are available for other streets in Doylestown (like Main Street) but nothing for the given street and city.

@tallytalwar
Copy link

Another example being:

301 Commons Park S, Stamford, CT 06902

Results are available for places having "Park" and "Commons" in different Connecticut cities.

@hkrishna
Copy link
Contributor

hkrishna commented Apr 6, 2015

At the moment, our address parser is pretty basic and all it does is looks for a delimiter (comma) and uses everything that follows , as the given city/state/country.

So, @ecgreb, 203 Union Street, Doylestown PA should the results you expect. And @tallytalwar I think in your case when you search for 301 Commons Park S, Stamford, CT it finds addresses in CT however, doesnt find the address you query for - this could be a data issue.

Thank you for reporting. This odd behavior will be fixed and fine-tuned when we implement/use a better address parser #40

@tallytalwar
Copy link

But how come nominatim was able to find it?

And even if say there is a data issue, should it not give results prioritizing state, then city... But I do not see any result from Stamford (or near stamford) in the list of suggested searches/places. Maybe it should prioritize based on a metric say distance from the given city.

@dianashk
Copy link
Contributor

dianashk commented Apr 6, 2015

The Stamford address is in osm as a way, not an address.
https://nominatim.openstreetmap.org/details.php?place_id=2577056971
Would that have an impact on the results?

The idea of sorting results by proximity to centroid of the admin area
specified in the query is good. This would again be feasible after we start
parsing the addresses smarter.

On Monday, April 6, 2015, Varun <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

But how come nominatim was able to find it?

And even if say there is a data issue, should it not give results
prioritizing state, then city... But I do not see any result from Stamford
(or near stamford) in the list of suggested searches/places. Maybe it
should prioritize based on a metric say distance from the given city.


Reply to this email directly or view it on GitHub
#67 (comment).

Diana Shkolnikov

267-243-1110
diana@mapzen.com

@stevevance
Copy link

@hkrishna Have you heard of usaddress from DataMade? It reads a string and parses the different address parts. It could be used to find the parts when the user doesn't include a comma delimiter.

@dianashk
Copy link
Contributor

dianashk commented Apr 9, 2015

@stevevance usaddress looks like a great starting point. Thanks. We will need to eventually find something that handles international address as well.

@dmunch
Copy link

dmunch commented Apr 14, 2015

Just had a quick look into useaddress, actually it's probabilistic and you can train it for different address patterns using http://parserator.datamade.us/

Not sure however how big the effort is to train it for lots of different countries.

@missinglink
Copy link
Member

I'm self-assigning this to investigate the potentially missing street data, this relates well to another ticket I'm currently working on.

related: #22

@cathydeng
Copy link

hey everyone - yep, usaddress is a probabilistic parser, and it performs pretty well on US addresses with all sorts of patterns/formats. you actually can't train the model on http://parserator.datamade.us/ - that just uses our existing model to parse new addresses.

we did put together a toolkit, https://github.com/datamade/parserator, for setting up new probabilistic parsers & training models. making a UK parser would involve some config tweaks (defining the possible address components in the UK, etc) & preparing labeled training data

I'd be happy to chat if you have any questions

@missinglink
Copy link
Member

cc/ @thatdatabaseguy re: libpostal

@missinglink missinglink removed their assignment Apr 29, 2015
@amnesia7
Copy link

Is the basic parser also the reason why I need to actually type in the , between the address parts when using the autocomplete on https://mapzen.com/pelias/ ?
Also, would the address parsing also allow things like returning places in NY if I actually type new york as part of the autocompleter?

@dianashk dianashk added this to the Address Parsing milestone Apr 21, 2016
@trescube
Copy link
Contributor

Create an acceptance test

@trescube
Copy link
Contributor

We'll pull some acceptance tests from this issue but the core address matches probably won't happen due to missing data. We will, however, fallback to the coarse geocode. Report to Al that 'CT' is broken.

@trescube
Copy link
Contributor

Original issue fixed, moved 301 Commons Park S, Stamford, CT 06902 to #440

@ghost ghost removed the on-deck label Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants