Update CI and Docker images to Ubuntu 22.04

[orangejulius]

Pelias relies on Ubuntu for it's CI and Docker images, and we're currently still running Ubuntu 18.04. This version will have LTS support through 2028, but Github Actions stopped using any Ubuntu 18.04 runners in April 2023.

Most of our CI uses Ubuntu 20.04, but our Docker images are still built on Ubuntu 18.04, so we should ideally move everything to Ubuntu 22.04 (as suggested by @missinglink in pelias/docker-baseimage#20) to stay current and ensure we don't have to mess with much for while longer.

[orangejulius]

@missinglink I'm probably going to spend a little time this weekend updating all our CI configs and Docker base image to use newer ubuntu versions. I agree with you we might as well go straight to Ubuntu 22 in general, and we should select Ubuntu 22 for our Docker baseimage.

Do you think there's any value in keeping Ubuntu 20 in our CI as well? It could be nice to support both but would mean more jobs in the matrix.

Also I'm thinking I'll use Github Actions variables so we can store the Ubuntu version we use across all projects in one place, and all our CI scripts can be updated without needing a commit to each repo. How's that sound?

[missinglink]

Sounds good, I haven't used variables but it sounds like a nice way of reducing the work to edit Configs across the various repos.

I don't see a huge value in keeping ubu 20 in the matrix, for docker we will likely settle on the latest stable OS quickly and for bare-metal, people run really old versions, one of my servers is still on an older version than that, so we'd never be able to cover all of them.

That said if we can do it and it's easy then why not, but if it requires a lot of conditional statements to support both i'd prefer to simply support the latest.

[orangejulius]

I've started testing out the GitHub Actions variable based approach to setting the Ubuntu version, it seems to work well and should be convenient going forward.

One annoying thing is we may have to reset a lot of our branch protection rules. If a master branch requires a particular unit test run to pass, it appears that the requirement pins to a specific nodejs and Ubuntu version. So we may have to manually update all of these.

[orangejulius]

Okay, I've gone through all our repos with Docker images and made sure they build on ubuntu-22. There was only one minor change required.

All our CI for our primary repos (services, importers, schema, etc) is now running ubuntu 22 as well. All the supporting library repos (like pelias/query, dbclient, etc) have yet to be updated but those are lower priority since they are implicitly tested by the primary repos. So we can get to them someday :)

Using the script below, run from a directory with all the pelias repos checked out, I can confirm everything builds on Ubuntu 22, so pelias/docker-baseimage#27 is now good to merge. After that merges, I'll kick off new Docker image builds using a no-op commit first to the docker-libpostal_baseimage repo (since its Docker image is a dependency for others), and then to all the other repos.

Then we should be all 100% moved to Ubuntu 22! 🥳

Script to check that all images build

#!/bin/bash

set -euo pipefail

importers="openstreetmap whosonfirst openaddresses polylines geonames transit csv-importer"
services="api placeholder libpostal-service interpolation pip-service"
libpostal_baseimage="docker-libpostal_baseimage"
schema="schema"

modules="pbf2json model query dbclient"
repos="$importers $services $schema"

echo $repos

for repo in $repos; do
        echo $repo
        pushd $repo
        pwd
        git stash
        git checkout master
        git fetch
        git pull
        git cleanup || true

        branch_name="docker-ubuntu-22"
        git branch -D $branch_name || true
        git checkout -b $branch_name || true

        sed -i 's/pelias\/baseimage/pelias\/baseimage\:ubuntu-22/' Dockerfile
        sed -i 's/pelias\/libpostal_baseimage/pelias\/libpostal_baseimage\:ubuntu-22/' Dockerfile

        docker build . -t pelias/$repo:ubuntu-22

        popd
done