Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run tests with empty config to ignore local config #41

Merged
merged 2 commits into from Feb 22, 2017
Merged

run tests with empty config to ignore local config #41

merged 2 commits into from Feb 22, 2017

Conversation

trescube
Copy link
Contributor

No description provided.

@trescube trescube self-assigned this Feb 22, 2017
missinglink
missinglink reviewed Feb 22, 2017
View reviewed changes
Copy link
Member

@missinglink missinglink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you use an ENV var such as PELIAS_CONFIG=default then I believe you don't need to commit an empy config file?

Otherwise maybe the config file could be inside the test directory and called something like pelias.test.config.json so it's clear what it does?

@trescube
Copy link
Contributor Author

moved

missinglink
missinglink approved these changes Feb 22, 2017
View reviewed changes
Copy link
Member

@missinglink missinglink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@trescube trescube merged commit 426088a into master Feb 22, 2017
@trescube trescube deleted the add-lodash-dep branch February 22, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@missinglink missinglink missinglink approved these changes

@orangejulius orangejulius Awaiting requested review from orangejulius

@dianashk dianashk Awaiting requested review from dianashk

Assignees

@trescube trescube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trescube @missinglink