Use a single stream for importing records #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new importer style requires records to be imported starting at the top of the heirarchy and working on down.
orangejulius
force-pushed
the
single-stream
branch
2 times, most recently
from
1bd19ca
to
5f56eb9
Compare
| // how to convert WOF records to Pelias Documents | ||
| var documentGenerator = peliasDocGenerators.create( | ||
| hierarchyFinder.hierarchies_walker(wofRecords)); | ||
| var readStream = readStream.create(directory, types, wofAdminRecords); |
There was a problem hiding this comment.
It's a bit confusing that you redefine readStream here and assign readStream.create() to it. Would be great if this variable or the one in the require block had a different name.
|
Other than the one confusing variable name, code looks solid. |
Previously, the WOF importer loaded all records into memory in one stream, and then processed and indexed the records in Elasticsearch in a second stream after the first stream was done. This has several problems: * It requires that all data can fit into memory. While this is not _so_ bad for WOF admin data, where a reasonably new machine can handle things just fine, it's horrible for venue data, where there are already 10s of millions of records. * Its slower: by separating the disk and network I/O sections, they can't be interleaved to speed things up. * It doesn't give good feedback when running the importer that something is happening: the importer sits for several minutes loading records before the dbclient progress logs start displaying This change fixes all those issues, by processing all records in a single stream, starting at the highest hierarchy level, and finishing at the lowest, so that all records always have the admin data they need to be processed. Fixes #101 Connects #7 Connects #94
orangejulius
force-pushed
the
single-stream
branch
from
5f56eb9
to
c500aaf
Compare
|
Variable name is fixed! |
|
|
1 similar comment
|
|
orangejulius
added a commit
that referenced
this pull request
Aug 16, 2016
I somehow messed up the order when working on #119. Since `county` records were being loaded and processed before `macrocounty` records, its possible that some records were missing the `macrocounty` hierarchy elements.
Merged
This was referenced Sep 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the WOF importer loaded all records into memory in one
stream, and then processed and indexed the records in Elasticsearch in a
second stream after the first stream was done.
This has several problems:
so bad for WOF admin data, where a reasonably new machine can handle
things just fine, it's horrible for venue data, where there are already
10s of millions of records and will likely be many more in the future.
can't be interleaved to speed things up.
is happening: the importer sits for several minutes loading records
before the dbclient progress logs start displaying
This change fixes all those issues, by processing all records in a
single stream, starting at the highest hierarchy level, and finishing at
the lowest, so that all records always have the admin data they need to
be processed.
A change like this is necessary to support Who's on First venues, and in fact this code has already been tested by importing about 1M venues from California!
Fixes #101
Connects #7 (it doesn't quite fix it, for that we need to be able to not even store all admin areas at once, for example to import geometries)
Connects #94