Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix varchar(191) by replacing with 255 #135

Closed
lancepioch opened this issue Apr 21, 2024 · 1 comment · Fixed by #376
Closed

Fix varchar(191) by replacing with 255 #135

lancepioch opened this issue Apr 21, 2024 · 1 comment · Fixed by #376
Labels
🐛 bug Something isn't working 🟡 medium Somewhat challenging
Milestone
beta6

Comments

@lancepioch
Copy link
Member

https://www.grouparoo.com/blog/varchar-191

https://stackoverflow.com/questions/43832166/laravel-5-4-specified-key-was-too-long-why-the-number-191
@Software-Noob
Copy link
Contributor

Software-Noob commented Apr 21, 2024 •
edited

https://laravel.com/docs/5.4/migrations#creating-indexes

The default was set to 191 55ae913 and never updated/removed after minimum MySQL version was updated

https://github.com/pelican-dev/panel/blob/main/app/Providers/AppServiceProvider.php#L28

@lancepioch lancepioch added 🐛 bug Something isn't working 🟡 medium Somewhat challenging labels May 17, 2024
@lancepioch lancepioch changed the title Investigate varchar(191) length issue [$50] Fix varchar(191) by replacing with 255 Jun 11, 2024
@lancepioch lancepioch added the 💵 bounty This issue is eligible for a payout label Jun 11, 2024
@RMartinOscar RMartinOscar mentioned this issue Jun 11, 2024
Merged
@lancepioch lancepioch removed the 💵 bounty This issue is eligible for a payout label Jun 12, 2024
@lancepioch lancepioch changed the title [$50] Fix varchar(191) by replacing with 255 Fix varchar(191) by replacing with 255 Jun 12, 2024
notAreYouScared pushed a commit that referenced this issue Jun 16, 2024
@RMartinOscar @lancepioch
Fix varchar(191) by replacing with 255 #135 (#376)
aa08e77 
* Add Nullable

* Edit filament & AppServiceProvider

* Pint

* Patch tests

* Actually patching tests

* Actually patching tests

* Remove length

* Remove defaultStringLength

* Let’s see the differences

---------

Co-authored-by: Lance Pioch <git@lance.sh>
@lancepioch lancepioch added this to the beta6 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working 🟡 medium Somewhat challenging
Projects
None yet
Milestone
beta6
Development

Successfully merging a pull request may close this issue.

Fix varchar(191) by replacing with 255 #135 RMartinOscar/panel
2 participants
@lancepioch @Software-Noob