Migrate to new namespace layout #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It showed incorrect tag and the syntax was not in a code block
Closes getpelican/pelican-plugins#69 Due to change in pelican code, `import EXTENSIONS` was no longer working.
Plugin reads files from `content/code/`, instead of `content/downloads/code/`.
- Works as the existing [octopress / jekyll plugin](https://gist.github.com/jamieowen/2063748)
It hides Download link
Lines [xxx] won't be shown if :hidetitle: is used
Seems like it wasn't tested because if file was in codec different from 'utf-8' it failed on reading
These tests check only basic functionality without any specific usecases
… CSS classes A regression was introduced few patches ago, which placed code inside the `figcaption` tag. This is not correct. The original version has this layout ``` figure figcaption code ``` This patch fixes this issue. It also encloses metadata, 1. title 2. filename 3. line number inside CSS classes. This let's themes improve the look of the figcaption. Previously, all the metadata was piled into one `<span>`.
Adding <iframe> adds 1.2MB of javascript to webpage. And tracking cookies. Instead we can add thumbnail of video and link it to YouTube page. So user can click to watch movie and is not tracked on our site. YOUTUBE_THUMB_ONLY liquid config flag enables this mode YOUTUBE_THUMB_SIZE allows to select one of YT thumbnails - there are four of them defined: - maxres: 1280x720 - sd: 640x360 - hq: 480x360 - mq: 320x180 'sd' one is used if not defined in LIQUID_CONFIGS variable.
LIQUID_TAGS is list of tags that should be made available to posts. It is optional, but if it is not provided, no tag will be loaded, making plugin essentially useless.
- document new LIQUID_TAGS setting - small updates to existing documentation
8 tasks
|
Outstanding work @mirekdlugosz ! I have nothing to say but I'm impressed with you huge effort. Everything is properly documented and all missing pieces are covered by a corresponding ticket. You made the right call overall: the little sacrifices are balanced and allows for this plugin to finally be standalone. So LGTM, let's merge! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating liquid-tags plugin to new namespace layout, based on instructions from drafted article on Pelican blog. Fixes #1 .
Linters don't report any errors, all tests pass and plugin is recognized by
pelican-pluginsafter installation. I tested most tags and checked if what they actually produce seems to resemble what they should be producing, although my testing was far from exhaustive.LIQUID_TAGSconfiguration settingMy work starts with commit deb688f ; I did clean up history a little, but I would like to keep these commits to have a record of code changes that must have been done during porting.
@justinmayer @kdeldycke please let me know what you think