refactor: remove xhtml2pdf / rst2pdf workaround #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wombelix
force-pushed
the
remove_rst2pdf_workaround
branch
from
8bbb84e
to
cde3780
Compare
Workaround not required anymore, fix included in rst2pdf since version 0.99 related rst2pdf/rst2pdf@6ad348c
wombelix
changed the title
wombelix
force-pushed
the
remove_rst2pdf_workaround
branch
from
cde3780
to
da2d3c9
Compare
justinmayer
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround not required anymore, fix included in rst2pdf since version 0.99
related rst2pdf/rst2pdf@6ad348c
@justinmayer apologies that I wasn't responsive during the last few months and thanks a lot that you took care about the pull requests for the pdf and touch plugin. I just saw that we can now get rid of a workaround I had to add two years ago.