Improve regex exclusion feature #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avaris
reviewed
Jul 10, 2023
|
Note that merging this would obsolete the fix proposed in #19 since it fixes the same issue |
- Compiles the regexes for performance - Fixes an oversight where exclusions weren't applied to txt-formatted sitemaps. - Switches to using `re.search` instead of `re.match` to match the documentation (ie. "containing" vs. "starting with") and changes the example to make it more obvious.
|
Also added a |
This was referenced Jul 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re.searchinstead ofre.matchto match the documentation (ie. "containing" vs. "starting with") and changes the example to make it more obvious.