fix: ignore flaky integration test on MacOS #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brayniac
approved these changes
Feb 6, 2023
hderms
added a commit
to hderms/pelikan
that referenced
this pull request
Feb 9, 2023
This reverts commit 572ed35.
brayniac
added a commit
that referenced
this pull request
Feb 19, 2023
Fixes a bug in the segcache cas implementation where no-expire and negative TTLs were treated incorrectly. Re-enables integration test on MacOS. (Reverts #58) --------- Co-authored-by: Brian Martin <brian@pelikan.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already manually ignoring this whenever it fails in CI so it might as well be marked as ignored until someone gets around to fixing it.
I have opened an issue to track the test failure in #59