Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuthFilter:oauth2_token to rejects headers that explicitly state oauth_version="1.0" #86

Merged
merged 1 commit into from Oct 20, 2011
Merged

OAuthFilter:oauth2_token to rejects headers that explicitly state oauth_version="1.0" #86

merged 1 commit into from Oct 20, 2011

Commits on Sep 23, 2011

  1. OAuthFilter:oauth2_token to rejects headers that explicitly state oau… 

    …th_version="1.0"

OAuth 1 allows whitespace between the header parameters, but this is optional.  OAuthFilter was using this optionsl behavior to discriminate between oauth1 and oauth2 tokens.  While most OAuth clients put whitespace between their parameters, some clients do not.  The filter was mis-identifying these tokens as OAuth2 tokens, breaking the authentication chain.

oauth2_token now checks if oauth_version="1.0".  If this is present, then the token is rejected.  oauth_version is an optional paramter.  When it is missing, oauth2_token then defaults to checking for whitespace between the parameters.
    @KentonWhite
    KentonWhite committed Sep 23, 2011
    Configuration menu
    Copy the full SHA
    72ae681 View commit details
    Browse the repository at this point in the history