Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Delete function to tree #256

Merged
merged 4 commits into from Mar 1, 2019
Merged

Conversation

zenmoto
Copy link
Contributor

@zenmoto zenmoto commented Dec 19, 2018

Issue: none filed

This PR simply adds a 'Delete' function to the tree so that keys can be removed programatically.

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #256 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   89.32%   89.33%   +0.01%     
==========================================
  Files           9        8       -1     
  Lines        1695     1679      -16     
==========================================
- Hits         1514     1500      -14     
+ Misses        129      126       -3     
- Partials       52       53       +1
Impacted Files Coverage Δ
toml.go 73.3% <83.33%> (+0.52%) ⬆️
token.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c6b39...798fb72. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #256 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   89.32%   89.58%   +0.26%     
==========================================
  Files           9        8       -1     
  Lines        1695     1680      -15     
==========================================
- Hits         1514     1505       -9     
+ Misses        129      124       -5     
+ Partials       52       51       -1
Impacted Files Coverage Δ
toml.go 75.36% <100%> (+2.58%) ⬆️
token.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c6b39...7358818. Read the comment docs.

@pelletier
Copy link
Owner

Looks good! Do you mind adding a DeletePath(keys []string) (akin to GetPath and SetPath) to keep the API uniform?

@pelletier pelletier merged commit ad2aec1 into pelletier:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants