Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode: handle LocalTime to interface{} unmarshal #567

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Decode: handle LocalTime to interface{} unmarshal #567

merged 6 commits into from
Jul 21, 2021

Conversation

kkHAIKE
Copy link
Contributor

@kkHAIKE kkHAIKE commented Jul 13, 2021

Issue: #566

add localtime decode support

@kkHAIKE kkHAIKE changed the base branch from master to v2 July 13, 2021 10:31
pelletier
pelletier requested changes Jul 20, 2021
View reviewed changes
Copy link
Owner

@pelletier pelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for fixing this. I'd love to see some tests before merging this.

@pelletier pelletier linked an issue Jul 20, 2021 that may be closed by this pull request
v2 miss Local Time parse #566
Closed
kkHAIKE and others added 4 commits July 21, 2021 12:16
@pelletier pelletier changed the title add localtime decode support Add LocalTime to interface{} decode support Jul 21, 2021
@pelletier
Copy link
Owner

Changed the tests to use Unmarshal so that it also covers the decoding code.

Thank you for the patch!

@pelletier pelletier merged commit 8be357d into pelletier:v2 Jul 21, 2021
@pelletier pelletier mentioned this pull request Jul 27, 2021
Closed
@pelletier pelletier mentioned this pull request Sep 8, 2021
Closed
@pelletier pelletier added the bug Issues describing a bug in go-toml. label Oct 28, 2021
@pelletier pelletier changed the title Add LocalTime to interface{} decode support Decode: handle LocalTime to interface{} unmarshal Oct 28, 2021
@oschwald oschwald mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelletier pelletier pelletier requested changes

Assignees
No one assigned
Labels
bug Issues describing a bug in go-toml.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2 miss Local Time parse
2 participants
@kkHAIKE @pelletier