Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode: make copy of non addressable values #576

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Decode: make copy of non addressable values #576

merged 1 commit into from
Sep 1, 2021

Conversation

pelletier
Copy link
Owner

Issue: #575

@pelletier
unmarshal: make copy of non addressable values
c615eaa 
When unmarshaling into a nested struct in a map, the value is not
addressable. In that case, make a copy of it and modify it instead.

Fixes #575
@pelletier
Copy link
Owner Author

@89z let me know if this patch fixes it for you!

@pelletier pelletier merged commit 1230ca4 into v2 Sep 1, 2021
@pelletier pelletier deleted the bug-575 branch September 1, 2021 00:22
@pelletier pelletier added the bug Issues describing a bug in go-toml. label Oct 28, 2021
@pelletier pelletier changed the title unmarshal: make copy of non addressable values Decode: make copy of non addressable values Oct 28, 2021
@oschwald oschwald mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Issues describing a bug in go-toml.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pelletier