Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode: fix error reporting for last comments #591

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Decode: fix error reporting for last comments #591

merged 2 commits into from
Sep 9, 2021

Conversation

pelletier
Copy link
Owner

Fixes #588

When an invalid TOML expression ends with a comment before the end of
file, the decode error would take a nil from scanComment, which is not
part of the document.
@pelletier pelletier merged commit f34c9c3 into v2 Sep 9, 2021
@pelletier pelletier deleted the issue-588 branch September 9, 2021 01:54
@pelletier pelletier changed the title scanner: fix error reporting for last comments Decode: fix error reporting for last comments Oct 28, 2021
@pelletier pelletier added the bug Issues describing a bug in go-toml. label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues describing a bug in go-toml.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant