Decode: fail when array is missing separator #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jidicula
force-pushed
the
ji/issue-613-array-missing-separator
branch
from
983d3d9
to
dc095fa
Compare
The toml-test generated test for an array with missing separators was failing since the parser wasn't noticing missing separators. This change leverages the zero value of `ast.Reference` (an int). The var is now declared outside the while block, and re-zeroed if the token is not a non-trailing comma. The parser checks if the previous value of `valueRef` is zero. The only time this check would pass is when the previous byte in the array was a whitespace, which would only be the case when an array is missing a separator. Resolves: part of pelletier#613
jidicula
force-pushed
the
ji/issue-613-array-missing-separator
branch
from
dc095fa
to
5875df6
Compare
|
Sorry for the late reply! Thank you for the patch! Adjusted it to return directly when the failure is detected. Note: the building is failing because CI does not run the |
Good call, I should have seen that. Thanks! |
pelletier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #613
The toml-test generated test for an array with missing separators was
failing since the parser wasn't noticing missing separators.
This change leverages the zero value of
ast.Reference(anint). Thevar is now declared outside the while block, and re-zeroed if the
token is not a non-trailing comma.
The parser checks if the previous value of
valueRefis zero. Theonly time this check would pass is when the previous byte in the array
was a whitespace, which would only be the case when an array is
missing a separator.
Fixes
go test -tags testsuite -run TestTOMLTest_Invalid_Array_MissingSeparator