Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a toml linter #74

Merged
merged 3 commits into from
Jun 6, 2016
Merged

Add a toml linter #74

merged 3 commits into from
Jun 6, 2016

Conversation

samb1729
Copy link
Contributor

@samb1729 samb1729 commented Jun 6, 2016

Supports stdin/stdout and also writing to files. Errors will be printed to stderr so they don't get piped to files unintentionally.

Based on #69

@coveralls
Copy link

coveralls commented Jun 6, 2016

Coverage Status

Coverage remained the same at 87.167% when pulling f0625b5 on sambooo:master into c187221 on pelletier:master.

os.Exit(-1)
}
io.WriteString(os.Stdout, s)
os.Exit(0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather see a if/else block here rather than os.Exit(0).

@pelletier
Copy link
Owner

That's great! Do you mind adding a --help flag that describe the purpose and usage of the program? I think it's important to mention that files will be modified in place.

@samb1729
Copy link
Contributor Author

samb1729 commented Jun 6, 2016

Usage() is called here by flag when -h or some invalid flags are passed

@pelletier
Copy link
Owner

Perfect. Thanks for your contribution!

@pelletier pelletier merged commit b39f6ef into pelletier:master Jun 6, 2016
@pelletier pelletier mentioned this pull request Jun 6, 2016
@coveralls
Copy link

coveralls commented Jun 6, 2016

Coverage Status

Coverage remained the same at 87.167% when pulling f2455e5 on sambooo:master into c187221 on pelletier:master.

@coveralls
Copy link

coveralls commented Jun 6, 2016

Coverage Status

Coverage remained the same at 87.167% when pulling 6a26cc6 on sambooo:master into c187221 on pelletier:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants