Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lint_strictly setting #28

Closed
ErinCall opened this issue Dec 20, 2019 · 0 comments · Fixed by #60
Closed

Add a lint_strictly setting #28

ErinCall opened this issue Dec 20, 2019 · 0 comments · Fixed by #60
Assignees
Labels
enhancement New feature or request

Comments

@ErinCall
Copy link
Contributor

I'm a big believer in treating warnings as errors. Sure, many warnings are false positives, but if a normal build has warnings, you're likely to overlook any new ones that indicate a real problem.

For the sake of the -Werr aficionados out there, add a lint_strictly setting¹ that sends the --strict flag to helm lint.

¹ Just calling it strict might be ok, but the struct field in internal/helm.Config should definitely have "Lint" in the name somewhere since the setting is specific to that command.

@ErinCall ErinCall added the enhancement New feature or request label Dec 20, 2019
@ErinCall ErinCall self-assigned this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant