Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the prefix setting #48

Closed
ErinCall opened this issue Dec 28, 2019 · 0 comments · Fixed by #50
Closed

Remove the prefix setting #48

ErinCall opened this issue Dec 28, 2019 · 0 comments · Fixed by #50
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@ErinCall
Copy link
Contributor

ErinCall commented Dec 28, 2019

The prefix setting in internal/helm/config.go exists because it existed in drone-helm. As I've learned more about drone usage, it's become clear it's not needed. It was meant to support a .drone.yml stanza like this:

pipeline:
  steps:
    - name: deploy_staging
      image: pelotech/drone-helm3
      prefix: stage
      secrets: [stage_kubernetes_token]

That secrets syntax is deprecated in recent versions of drone, and might not work at all. A modern stanza would look like this:

pipeline:
  steps:
    - name: deploy_staging
      image: pelotech/drone-helm3
      kubernetes_token:
        from_secret: stage_kubernetes_token
  • Remove the setting and associated code from config.go
  • Remove any mention of the setting (including the "using the prefix setting" section) from parameter_reference.md
  • In the "upgrading from drone-helm" section of the README, add a note that the old syntax needs to be replaced
@ErinCall ErinCall added the documentation Improvements or additions to documentation label Dec 28, 2019
@ErinCall ErinCall changed the title Give useful examples of the prefix setting Remove the prefix setting Dec 30, 2019
ErinCall added a commit that referenced this issue Dec 31, 2019
The setting isn't necessary with modern versions of Drone, and it
creates a lot of edge-cases. The use-case doesn't justify the added
complexity.
@ErinCall ErinCall self-assigned this Dec 31, 2019
ErinCall added a commit that referenced this issue Dec 31, 2019
Remove support for the prefix setting [#48]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant