Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR template should mention syncing config changes to drone-plugin-index #63

Closed
ErinCall opened this issue Jan 3, 2020 · 0 comments · Fixed by #70
Closed

PR template should mention syncing config changes to drone-plugin-index #63

ErinCall opened this issue Jan 3, 2020 · 0 comments · Fixed by #70
Labels
documentation Improvements or additions to documentation

Comments

@ErinCall
Copy link
Contributor

ErinCall commented Jan 3, 2020

What needs explanation:
In addition to parameter_reference.md, there is a parameter reference in drone-plugin-index. If someone makes changes to the available settings, they need to make a corresponding change to that parameter reference. That's easy to forget.

Update .github/pull_request_template.md to mention that config changes need to go over there as well.
@ErinCall ErinCall added the documentation Improvements or additions to documentation label Jan 3, 2020
ErinCall added a commit that referenced this issue Jan 7, 2020
@ErinCall
Mention the external docs in the PR template [#63]
55017ee 
I just opened a PR with a config change and forgot about the plugin-
index docs...must be time to get around to this issue.
@ErinCall ErinCall mentioned this issue Jan 7, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mention the external docs in the PR template pelotech/drone-helm3
1 participant
@ErinCall