Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove build/drone-helm from the repo #93

Closed
ErinCall opened this issue May 22, 2020 · 1 comment
Closed

Remove build/drone-helm from the repo #93

ErinCall opened this issue May 22, 2020 · 1 comment
Labels
code quality Improvements to the internals that may not have user-facing impact

Comments

@ErinCall
Copy link
Contributor

The built binary is supposed to be .gitignored, but has been inadvertently added. It's just short of 4 MB, and since git doesn't do a very good job of managing large files, leaving it committed will have an outsized impact on clone/fetch operations.
@ErinCall ErinCall added the code quality Improvements to the internals that may not have user-facing impact label May 22, 2020
ErinCall added a commit that referenced this issue May 22, 2020
@ErinCall
Remove the built binary [#93]
3fea592 
It was never supposed to be part of the repo, and currently accounts for
at least half of the .git directory's size. We need to nip it in the bud
before `git clone` times become unmanageable!
@ErinCall ErinCall mentioned this issue May 22, 2020
Merged
3 tasks
@ErinCall
Copy link
Contributor Author

The file should still go away, but...this isn't nearly as big a deal as I thought it was. My drone-helm3/.git directory is over 17MB, but a fresh clone is only about 3MB. I guess I just have a big honkin' pile of rebased/amended commits?

ErinCall added a commit that referenced this issue May 23, 2020
@ErinCall
Ignore build/* [#93]
91d4506 
I definitely thought this rule was already in effect--I had a
`build/.gitignore` that contained just `*`. Unfortunately, that makes
git ignore the .gitignore file itself, so it was never added to the
repo...
@josmo josmo closed this as completed in #94 May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improvements to the internals that may not have user-facing impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ErinCall