Remove the TODO list from README.md #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything on the checklist has been converted to a github issue, so it's redundant.
ErinCall
commented
Dec 17, 2019
README.md
Outdated
| * [x] Make `golint` part of the build process (and make it pass) | ||
| * [x] Implement debug output | ||
| * [x] Flesh out `helm upgrade` until it's capable of working | ||
| * [ ] Implement config settings for `upgrade` |
| * [x] Implement debug output | ||
| * [x] Flesh out `helm upgrade` until it's capable of working | ||
| * [ ] Implement config settings for `upgrade` | ||
| * [ ] Implement `helm lint` |
| * [x] Flesh out `helm upgrade` until it's capable of working | ||
| * [ ] Implement config settings for `upgrade` | ||
| * [ ] Implement `helm lint` | ||
| * [ ] Implement `helm delete` |
| * [ ] Implement config settings for `upgrade` | ||
| * [ ] Implement `helm lint` | ||
| * [ ] Implement `helm delete` | ||
| * [ ] Look for command-line flags added in helm3; implement them |
| * [ ] Implement `helm lint` | ||
| * [ ] Implement `helm delete` | ||
| * [ ] Look for command-line flags added in helm3; implement them | ||
| * [ ] EKS support |
| * [ ] EKS support | ||
| * [ ] Dotenv support | ||
| * [ ] Example drone config in this README | ||
| * [ ] Change `.drone.yml` to use a real docker registry |
|
|
||
| Nice-to-haves: | ||
|
|
||
| * [ ] Cleanup() method on Steps to close open filehandles, etc. |
There was a problem hiding this comment.
WONTFIX: this would be a responsible practice on a persistent machine, but I don't think it's necessary in Drone's ephemeral containers.
| Nice-to-haves: | ||
|
|
||
| * [ ] Cleanup() method on Steps to close open filehandles, etc. | ||
| * [ ] Replace `fmt.Printf` with an actual logger |
|
|
||
| * [ ] Cleanup() method on Steps to close open filehandles, etc. | ||
| * [ ] Replace `fmt.Printf` with an actual logger | ||
| * [ ] Replace `fmt.Errorf` with `github.com/pkg/errors.Wrap`, since the built-in `Unwrap` doesn't work the way `Cause` does |
There was a problem hiding this comment.
WONTFIX: Unwrap works well enough for the rare situation where we might want access to the original error
| * [ ] Cleanup() method on Steps to close open filehandles, etc. | ||
| * [ ] Replace `fmt.Printf` with an actual logger | ||
| * [ ] Replace `fmt.Errorf` with `github.com/pkg/errors.Wrap`, since the built-in `Unwrap` doesn't work the way `Cause` does | ||
| * [ ] Deprecation warnings if there are environment variables that aren't applicable in helm3 |
grinnellian
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything on the checklist has been converted to a github issue, so we don't need the checklist any more.