Skip to content

Commit

Permalink
Change region implementation names to eliminate the 'mi' prefix
Browse files Browse the repository at this point in the history
This prepares the file to be moved from mi to dix. This patch
was done mechanically with the included scripts 'fix-miregion' run over
the entire X server and 'fix-miregion-private' run over
include/regionstr.h and mi/miregion.c.

Reviewed-by: Jamey Sharp <jamey@minilop.net>
Signed-off-by: Keith Packard <keithp@keithp.com>
  • Loading branch information
keith-packard committed Jun 6, 2010
1 parent 1768e51 commit 9b6f5f5
Show file tree
Hide file tree
Showing 10 changed files with 192 additions and 149 deletions.
4 changes: 2 additions & 2 deletions dix/window.c
Expand Up @@ -195,7 +195,7 @@ PrintChildren(WindowPtr p1, int indent)
ErrorF("[dix] ");
for (i=0; i<indent; i++) ErrorF(" ");
ErrorF("%lx\n", p1->drawable.id);
miPrintRegion(&p1->clipList);
RegionPrint(&p1->clipList);
PrintChildren(p2, indent+4);
p1 = p1->nextSib;
}
Expand All @@ -211,7 +211,7 @@ PrintWindowTree(void)
{
ErrorF("[dix] WINDOW %d\n", i);
pWin = screenInfo.screens[i]->root;
miPrintRegion(&pWin->clipList);
RegionPrint(&pWin->clipList);
p1 = pWin->firstChild;
PrintChildren(p1, 4);
}
Expand Down
2 changes: 1 addition & 1 deletion exa/exa_accel.c
Expand Up @@ -407,7 +407,7 @@ exaHWCopyNtoN (DrawablePtr pSrcDrawable,
rects[i].height = pbox[i].y2 - pbox[i].y1;
}

/* This must match the miRegionCopy() logic for reversing rect order */
/* This must match the RegionCopy() logic for reversing rect order */
if (nbox == 1 || (dx > 0 && dy > 0) ||
(pDstDrawable != pSrcDrawable &&
(pDstDrawable->type != DRAWABLE_WINDOW ||
Expand Down
4 changes: 2 additions & 2 deletions fb/fbpixmap.c
Expand Up @@ -115,7 +115,7 @@ if (((rx1) < (rx2)) && ((ry1) < (ry2)) && \
{ \
if ((reg)->data->numRects == (reg)->data->size) \
{ \
miRectAlloc(reg, 1); \
RegionRectAlloc(reg, 1); \
fr = REGION_BOXPTR(reg); \
r = fr + (reg)->data->numRects; \
} \
Expand Down Expand Up @@ -315,7 +315,7 @@ fbPixmapToRegion(PixmapPtr pPix)

fbFinishAccess(&pPix->drawable);
#ifdef DEBUG
if (!miValidRegion(pReg))
if (!RegionIsValid(pReg))
FatalError("Assertion failed file %s, line %d: expr\n", __FILE__, __LINE__);
#endif
return(pReg);
Expand Down
29 changes: 29 additions & 0 deletions fix-miregion
@@ -0,0 +1,29 @@
#!/bin/sh
sed -i \
-e 's/miRegionCreate\b/RegionCreate/g' \
-e 's/miRegionInit\b/RegionInit/g' \
-e 's/miRegionDestroy\b/RegionDestroy/g' \
-e 's/miRegionUninit\b/RegionUninit/g' \
-e 's/miRegionCopy\b/RegionCopy/g' \
-e 's/miIntersect\b/RegionIntersect/g' \
-e 's/miUnion\b/RegionUnion/g' \
-e 's/miRegionAppend\b/RegionAppend/g' \
-e 's/miRegionValidate\b/RegionValidate/g' \
-e 's/miRectsToRegion\b/RegionFromRects/g' \
-e 's/miSubtract\b/RegionSubtract/g' \
-e 's/miInverse\b/RegionInverse/g' \
-e 's/miRectIn\b/RegionContainsRect/g' \
-e 's/miTranslateRegion\b/RegionTranslate/g' \
-e 's/miRegionReset\b/RegionReset/g' \
-e 's/miRegionBreak\b/RegionBreak/g' \
-e 's/miPointInRegion\b/RegionContainsPoint/g' \
-e 's/miRegionEqual\b/RegionEqual/g' \
-e 's/miRegionNotEmpty\b/RegionNotEmpty/g' \
-e 's/miRegionEmpty\b/RegionEmpty/g' \
-e 's/miRegionExtents\b/RegionExtents/g' \
-e 's/miPrintRegion\b/RegionPrint/g' \
-e 's/miRectAlloc\b/RegionRectAlloc/g' \
-e 's/miValidRegion\b/RegionIsValid/g' \
-e 's/miRegionBroken\b/RegionBroken/g' \
-e 's/miClipSpans\b/RegionClipSpans/g' \
"$@"
14 changes: 14 additions & 0 deletions fix-miregion-private
@@ -0,0 +1,14 @@
#!/bin/sh
sed -i \
-e 's/miEmptyBox\b/RegionEmptyBox/g' \
-e 's/miEmptyData\b/RegionEmptyData/g' \
-e 's/miBrokenData\b/RegionBrokenData/g' \
-e 's/miBrokenRegion\b/RegionBrokenRegion/g' \
-e 's/miCoalesce\b/RegionCoalesce/g' \
-e 's/miAppendNonO\b/RegionAppendNonO/g' \
-e 's/miRegionOp\b/RegionOp/g' \
-e 's/miSetExtents\b/RegionSetExtents/g' \
-e 's/miIntersectO\b/RegionIntersectO/g' \
-e 's/miUnionO\b/RegionUnionO/g' \
-e 's/miSubtractO\b/RegionSubtractO/g' \
"$@"
92 changes: 46 additions & 46 deletions include/regionstr.h
Expand Up @@ -66,13 +66,13 @@ typedef struct pixman_region16 RegionRec, *RegionPtr;

typedef struct pixman_region16_data RegDataRec, *RegDataPtr;

extern _X_EXPORT BoxRec miEmptyBox;
extern _X_EXPORT RegDataRec miEmptyData;
extern _X_EXPORT RegDataRec miBrokenData;
extern _X_EXPORT BoxRec RegionEmptyBox;
extern _X_EXPORT RegDataRec RegionEmptyData;
extern _X_EXPORT RegDataRec RegionBrokenData;

#define REGION_NIL(reg) ((reg)->data && !(reg)->data->numRects)
/* not a region */
#define REGION_NAR(reg) ((reg)->data == &miBrokenData)
#define REGION_NAR(reg) ((reg)->data == &RegionBrokenData)
#define REGION_NUM_RECTS(reg) ((reg)->data ? (reg)->data->numRects : 1)
#define REGION_SIZE(reg) ((reg)->data ? (reg)->data->size : 0)
#define REGION_RECTS(reg) ((reg)->data ? (BoxPtr)((reg)->data + 1) \
Expand All @@ -84,52 +84,52 @@ extern _X_EXPORT RegDataRec miBrokenData;
#define REGION_SZOF(n) (sizeof(RegDataRec) + ((n) * sizeof(BoxRec)))

#define REGION_CREATE(_pScreen, _rect, _size) \
miRegionCreate(_rect, _size)
RegionCreate(_rect, _size)

#define REGION_COPY(_pScreen, dst, src) \
miRegionCopy(dst, src)
RegionCopy(dst, src)

#define REGION_DESTROY(_pScreen, _pReg) \
miRegionDestroy(_pReg)
RegionDestroy(_pReg)

#define REGION_INTERSECT(_pScreen, newReg, reg1, reg2) \
miIntersect(newReg, reg1, reg2)
RegionIntersect(newReg, reg1, reg2)

#define REGION_UNION(_pScreen, newReg, reg1, reg2) \
miUnion(newReg, reg1, reg2)
RegionUnion(newReg, reg1, reg2)

#define REGION_SUBTRACT(_pScreen, newReg, reg1, reg2) \
miSubtract(newReg, reg1, reg2)
RegionSubtract(newReg, reg1, reg2)

#define REGION_INVERSE(_pScreen, newReg, reg1, invRect) \
miInverse(newReg, reg1, invRect)
RegionInverse(newReg, reg1, invRect)

#define REGION_TRANSLATE(_pScreen, _pReg, _x, _y) \
miTranslateRegion(_pReg, _x, _y)
RegionTranslate(_pReg, _x, _y)

#define RECT_IN_REGION(_pScreen, _pReg, prect) \
miRectIn(_pReg, prect)
RegionContainsRect(_pReg, prect)

#define POINT_IN_REGION(_pScreen, _pReg, _x, _y, prect) \
miPointInRegion(_pReg, _x, _y, prect)
RegionContainsPoint(_pReg, _x, _y, prect)

#define REGION_APPEND(_pScreen, dstrgn, rgn) \
miRegionAppend(dstrgn, rgn)
RegionAppend(dstrgn, rgn)

#define REGION_VALIDATE(_pScreen, badreg, pOverlap) \
miRegionValidate(badreg, pOverlap)
RegionValidate(badreg, pOverlap)

#define BITMAP_TO_REGION(_pScreen, pPix) \
(*(_pScreen)->BitmapToRegion)(pPix) /* no mi version?! */

#define RECTS_TO_REGION(_pScreen, nrects, prect, ctype) \
miRectsToRegion(nrects, prect, ctype)
RegionFromRects(nrects, prect, ctype)

#define REGION_EQUAL(_pScreen, _pReg1, _pReg2) \
miRegionEqual(_pReg1, _pReg2)
RegionEqual(_pReg1, _pReg2)

#define REGION_BREAK(_pScreen, _pReg) \
miRegionBreak(_pReg)
RegionBreak(_pReg)

#define REGION_INIT(_pScreen, _pReg, _rect, _size) \
{ \
Expand All @@ -140,15 +140,15 @@ extern _X_EXPORT RegDataRec miBrokenData;
} \
else \
{ \
(_pReg)->extents = miEmptyBox; \
(_pReg)->extents = RegionEmptyBox; \
if (((_size) > 1) && ((_pReg)->data = \
(RegDataPtr)malloc(REGION_SZOF(_size)))) \
{ \
(_pReg)->data->size = (_size); \
(_pReg)->data->numRects = 0; \
} \
else \
(_pReg)->data = &miEmptyData; \
(_pReg)->data = &RegionEmptyData; \
} \
}

Expand Down Expand Up @@ -179,16 +179,16 @@ extern _X_EXPORT RegDataRec miBrokenData;
REGION_UNINIT(_pScreen, _pReg); \
(_pReg)->extents.x2 = (_pReg)->extents.x1; \
(_pReg)->extents.y2 = (_pReg)->extents.y1; \
(_pReg)->data = &miEmptyData; \
(_pReg)->data = &RegionEmptyData; \
}

#define REGION_EXTENTS(_pScreen, _pReg) \
(&(_pReg)->extents)

#define REGION_NULL(_pScreen, _pReg) \
{ \
(_pReg)->extents = miEmptyBox; \
(_pReg)->data = &miEmptyData; \
(_pReg)->extents = RegionEmptyBox; \
(_pReg)->data = &RegionEmptyData; \
}

#ifndef REGION_NULL
Expand All @@ -200,94 +200,94 @@ extern _X_EXPORT RegDataRec miBrokenData;

extern _X_EXPORT void InitRegions (void);

extern _X_EXPORT RegionPtr miRegionCreate(
extern _X_EXPORT RegionPtr RegionCreate(
BoxPtr /*rect*/,
int /*size*/);

extern _X_EXPORT void miRegionInit(
extern _X_EXPORT void RegionInit(
RegionPtr /*pReg*/,
BoxPtr /*rect*/,
int /*size*/);

extern _X_EXPORT void miRegionDestroy(
extern _X_EXPORT void RegionDestroy(
RegionPtr /*pReg*/);

extern _X_EXPORT void miRegionUninit(
extern _X_EXPORT void RegionUninit(
RegionPtr /*pReg*/);

extern _X_EXPORT Bool miRegionCopy(
extern _X_EXPORT Bool RegionCopy(
RegionPtr /*dst*/,
RegionPtr /*src*/);

extern _X_EXPORT Bool miIntersect(
extern _X_EXPORT Bool RegionIntersect(
RegionPtr /*newReg*/,
RegionPtr /*reg1*/,
RegionPtr /*reg2*/);

extern _X_EXPORT Bool miUnion(
extern _X_EXPORT Bool RegionUnion(
RegionPtr /*newReg*/,
RegionPtr /*reg1*/,
RegionPtr /*reg2*/);

extern _X_EXPORT Bool miRegionAppend(
extern _X_EXPORT Bool RegionAppend(
RegionPtr /*dstrgn*/,
RegionPtr /*rgn*/);

extern _X_EXPORT Bool miRegionValidate(
extern _X_EXPORT Bool RegionValidate(
RegionPtr /*badreg*/,
Bool * /*pOverlap*/);

extern _X_EXPORT RegionPtr miRectsToRegion(
extern _X_EXPORT RegionPtr RegionFromRects(
int /*nrects*/,
xRectanglePtr /*prect*/,
int /*ctype*/);

extern _X_EXPORT Bool miSubtract(
extern _X_EXPORT Bool RegionSubtract(
RegionPtr /*regD*/,
RegionPtr /*regM*/,
RegionPtr /*regS*/);

extern _X_EXPORT Bool miInverse(
extern _X_EXPORT Bool RegionInverse(
RegionPtr /*newReg*/,
RegionPtr /*reg1*/,
BoxPtr /*invRect*/);

extern _X_EXPORT int miRectIn(
extern _X_EXPORT int RegionContainsRect(
RegionPtr /*region*/,
BoxPtr /*prect*/);

extern _X_EXPORT void miTranslateRegion(
extern _X_EXPORT void RegionTranslate(
RegionPtr /*pReg*/,
int /*x*/,
int /*y*/);

extern _X_EXPORT void miRegionReset(
extern _X_EXPORT void RegionReset(
RegionPtr /*pReg*/,
BoxPtr /*pBox*/);

extern _X_EXPORT Bool miRegionBreak(
extern _X_EXPORT Bool RegionBreak(
RegionPtr /*pReg*/);

extern _X_EXPORT Bool miPointInRegion(
extern _X_EXPORT Bool RegionContainsPoint(
RegionPtr /*pReg*/,
int /*x*/,
int /*y*/,
BoxPtr /*box*/);

extern _X_EXPORT Bool miRegionEqual(
extern _X_EXPORT Bool RegionEqual(
RegionPtr /*pReg1*/,
RegionPtr /*pReg2*/);

extern _X_EXPORT Bool miRegionNotEmpty(
extern _X_EXPORT Bool RegionNotEmpty(
RegionPtr /*pReg*/);

extern _X_EXPORT void miRegionEmpty(
extern _X_EXPORT void RegionEmpty(
RegionPtr /*pReg*/);

extern _X_EXPORT BoxPtr miRegionExtents(
extern _X_EXPORT BoxPtr RegionExtents(
RegionPtr /*pReg*/);

extern _X_EXPORT void miPrintRegion(
extern _X_EXPORT void RegionPrint(
RegionPtr /*pReg*/);

#endif /* REGIONSTRUCT_H */
6 changes: 3 additions & 3 deletions mi/mi.h
Expand Up @@ -422,18 +422,18 @@ extern _X_EXPORT void miPushPixels(

/* see also region.h */

extern _X_EXPORT Bool miRectAlloc(
extern _X_EXPORT Bool RegionRectAlloc(
RegionPtr /*pRgn*/,
int /*n*/
);

#ifdef DEBUG
extern _X_EXPORT Bool miValidRegion(
extern _X_EXPORT Bool RegionIsValid(
RegionPtr /*prgn*/
);
#endif

extern _X_EXPORT Bool miRegionBroken(RegionPtr pReg);
extern _X_EXPORT Bool RegionBroken(RegionPtr pReg);

/* miscrinit.c */

Expand Down

0 comments on commit 9b6f5f5

Please sign in to comment.