Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backward-cpp library (for M1 Macs) #38

Closed
blake-riley opened this issue Mar 29, 2022 · 1 comment
Closed

Update backward-cpp library (for M1 Macs) #38

blake-riley opened this issue Mar 29, 2022 · 1 comment

Comments

@blake-riley
Copy link

blake-riley commented Mar 29, 2022

Hi Paul,

Yoshitaka's Homebrew script is fantastic. Coot pre-1.0 almost builds on the fancy, new M1 processors.

At the moment, compilation on Apple Silicon fails on utils/backward.hpp. A short patch (see bombela/backward-cpp#201) is all that's blocking compilation.

diff --git a/utils/backward.hpp b/utils/backward.hpp
index 195ca8f2d..e661ce7b6 100644
--- a/utils/backward.hpp
+++ b/utils/backward.hpp
@@ -4157,7 +4157,11 @@ class SignalHandling {
 #elif defined(__arm__)
     error_addr = reinterpret_cast<void *>(uctx->uc_mcontext.arm_pc);
 #elif defined(__aarch64__)
-    error_addr = reinterpret_cast<void *>(uctx->uc_mcontext.pc);
+    #if defined(__APPLE__)
+      error_addr = reinterpret_cast<void *>(uctx->uc_mcontext->__ss.__pc);
+    #else
+      error_addr = reinterpret_cast<void *>(uctx->uc_mcontext.pc);
+    #endif
 #elif defined(__mips__)
     error_addr = reinterpret_cast<void *>(
         reinterpret_cast<struct sigcontext *>(&uctx->uc_mcontext)->sc_pc);

You might wish to:

  1. Apply this diff, or
  2. Bump your version of backward-cpp to the latest release v1.6, which includes this patch

Cheers for Coot!
Blake

@pemsley
Copy link
Owner

pemsley commented Apr 1, 2022

Hi Blake, I had intended for backward to be conditionally compiled (default not) and changed the configure script to do so in e633e2d. I will check out the newer version of backward and see how that works. Thanks.

@pemsley pemsley closed this as completed Apr 1, 2022
pemsley pushed a commit that referenced this issue Jun 7, 2023
…th-text-and-icons-inside-buttons-needs-to-be-brought-back

Support for displaying both text and icons inside buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants