Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip pushing docker images if pull requests are sent from fork repositories #2328

Merged
merged 2 commits into from Feb 23, 2024

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Feb 23, 2024

#2326 (comment)

The push of docker images failed because GitHub Actions tokens don't have the write permission if pull requests are sent from fork repositories.

So this pull request skip pushing docker images if pull requests are sent from fork repositories.

Test

The job passed.

https://github.com/pen-lang/pen/actions/runs/8014083453/job/21892121705?pr=2328#step:5:4

push: false

…positories

pen-lang#2326 (comment)

The push of docker images failed because GitHub Actions tokens don't have the write permission if pull requests are sent from fork repositories.
@@ -25,6 +25,6 @@ jobs:
- uses: docker/build-push-action@v5
with:
context: .
push: true
push: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (f9311ab) to head (fe2a389).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2328   +/-   ##
=======================================
  Coverage   87.88%   87.88%           
=======================================
  Files         455      455           
  Lines       55042    55042           
=======================================
  Hits        48375    48375           
  Misses       6667     6667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suzuki-shunsuke
Copy link
Contributor Author

🤔 I'm not sure why the job failed.

https://github.com/pen-lang/pen/actions/runs/8014083458/job/21892122367?pr=2328

error[E0635]: unknown feature `stdsimd`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.6/src/lib.rs:99:42
   |
99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
   |                                          ^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `ahash` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review February 23, 2024 03:11
@raviqqe raviqqe enabled auto-merge (squash) February 23, 2024 03:18
@raviqqe
Copy link
Contributor

raviqqe commented Feb 23, 2024

Thanks for the change again!

🤔 I'm not sure why the job failed

I guess that Rust Nightly removed the feature but the ahash crate still depends on it. We can ignore it for now.

Updating it fixed it! #2329

@raviqqe raviqqe merged commit 7ca70ff into pen-lang:main Feb 23, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants