Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map type in Core package #676

Merged
merged 55 commits into from
Jan 31, 2022
Merged

Map type in Core package #676

merged 55 commits into from
Jan 31, 2022

Conversation

raviqqe
Copy link
Contributor

@raviqqe raviqqe commented Jan 23, 2022

Depends-on: #715.

Close #654.

@raviqqe raviqqe added the merge label Jan 23, 2022
@raviqqe raviqqe changed the title Ignore lib/core Map type in Core package Jan 23, 2022
@raviqqe raviqqe removed the merge label Jan 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #676 (5a30fd5) into main (fec5cf9) will increase coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 5a30fd5 differs from pull request most recent head 5c4a3ff. Consider uploading reports for the commit 5c4a3ff to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
+ Coverage   85.71%   85.83%   +0.11%     
==========================================
  Files         308      308              
  Lines       28760    28719      -41     
==========================================
- Hits        24651    24650       -1     
+ Misses       4109     4069      -40     
Impacted Files Coverage Δ
cmd/pen/src/compile_configuration.rs 0.00% <0.00%> (ø)
lib/hir-mir/src/test_function_compiler.rs 0.00% <0.00%> (ø)
lib/hir-mir/src/error_type_configuration.rs 100.00% <0.00%> (ø)
...e_compiler/prelude_type_configuration_qualifier.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec5cf9...5c4a3ff. Read the comment docs.

@raviqqe
Copy link
Contributor Author

raviqqe commented Jan 30, 2022

There seems to be a kind of a bug in compilation of a Core'Map'hamt'setWithHash function, where a return address after the very last continuation function gets overwritten.

It doesn't seem to be due to a large number of arguments of the function though because bundling those arguments into a record didn't work.

@raviqqe raviqqe added the merge label Jan 31, 2022
@raviqqe
Copy link
Contributor Author

raviqqe commented Jan 31, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2022

refresh

✅ Pull request refreshed

@raviqqe
Copy link
Contributor Author

raviqqe commented Jan 31, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2022

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 74e4450 into main Jan 31, 2022
@mergify mergify bot deleted the feature/map-type-library branch January 31, 2022 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map data structure library
2 participants