Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate unused error types #799

Merged
merged 16 commits into from
Mar 2, 2022
Merged

Validate unused error types #799

merged 16 commits into from
Mar 2, 2022

Conversation

raviqqe
Copy link
Contributor

@raviqqe raviqqe commented Feb 28, 2022

Close #791.

@raviqqe raviqqe added the merge label Feb 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #799 (fd10dde) into main (ae67b6f) will increase coverage by 0.08%.
The diff coverage is 97.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   85.32%   85.41%   +0.08%     
==========================================
  Files         316      317       +1     
  Lines       29297    29466     +169     
==========================================
+ Hits        24999    25168     +169     
  Misses       4298     4298              
Impacted Files Coverage Δ
lib/hir-mir/src/error.rs 0.77% <0.00%> (-0.02%) ⬇️
...b/hir-mir/src/validation/unused_error_validator.rs 98.79% <98.79%> (ø)
lib/hir-mir/src/lib.rs 88.23% <100.00%> (+0.04%) ⬆️
lib/hir/src/analysis/ir/expression_visitor.rs 72.82% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae67b6f...fd10dde. Read the comment docs.

@mergify mergify bot merged commit d7877db into main Mar 2, 2022
@mergify mergify bot deleted the feature/validate-result-type branch March 2, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate unused result types
2 participants