Skip to content

Commit

Permalink
net: drop NET dependency from HAVE_BPF_JIT
Browse files Browse the repository at this point in the history
There is no point having the NET dependency on the select target, as it
forces all users to depend on NET to tell they support BPF_JIT.  Move
the config option to the bottom of the file - this could be a nice place
also for future "selectable" config symbols.

Fix up all users to drop the dependency on NET now that it is not
required to supress warnings for non-NET builds.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: David Miller <davem@davemloft.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
sravnborg authored and torvalds committed May 21, 2012
1 parent 8e95a53 commit e47b65b
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion arch/arm/Kconfig
Expand Up @@ -33,7 +33,7 @@ config ARM
select GENERIC_IRQ_SHOW
select CPU_PM if (SUSPEND || CPU_IDLE)
select GENERIC_PCI_IOMAP
select HAVE_BPF_JIT if NET
select HAVE_BPF_JIT
help
The ARM series is a line of low-power-consumption RISC chip designs
licensed by ARM Ltd and targeted at embedded applications and
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/Kconfig
Expand Up @@ -141,7 +141,7 @@ config PPC
select IRQ_FORCED_THREADING
select HAVE_RCU_TABLE_FREE if SMP
select HAVE_SYSCALL_TRACEPOINTS
select HAVE_BPF_JIT if (PPC64 && NET)
select HAVE_BPF_JIT if PPC64
select HAVE_ARCH_JUMP_LABEL
select ARCH_HAVE_NMI_SAFE_CMPXCHG

Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/Kconfig
Expand Up @@ -30,7 +30,7 @@ config SPARC
select USE_GENERIC_SMP_HELPERS if SMP
select GENERIC_PCI_IOMAP
select HAVE_NMI_WATCHDOG if SPARC64
select HAVE_BPF_JIT if NET
select HAVE_BPF_JIT

config SPARC32
def_bool !64BIT
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/Kconfig
Expand Up @@ -77,7 +77,7 @@ config X86
select GENERIC_CLOCKEVENTS_MIN_ADJUST
select IRQ_FORCED_THREADING
select USE_GENERIC_SMP_HELPERS if SMP
select HAVE_BPF_JIT if (X86_64 && NET)
select HAVE_BPF_JIT if X86_64
select CLKEVT_I8253
select ARCH_HAVE_NMI_SAFE_CMPXCHG
select GENERIC_IOMAP
Expand Down
7 changes: 4 additions & 3 deletions net/Kconfig
Expand Up @@ -246,9 +246,6 @@ config BQL
select DQL
default y

config HAVE_BPF_JIT
bool

config BPF_JIT
bool "enable BPF Just In Time compiler"
depends on HAVE_BPF_JIT
Expand Down Expand Up @@ -340,3 +337,7 @@ source "net/nfc/Kconfig"


endif # if NET

# Used by archs to tell that they support BPF_JIT
config HAVE_BPF_JIT
bool

0 comments on commit e47b65b

Please sign in to comment.