Filename suggestion (numbers) for new layers in Pencil2D #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrStevns
reviewed
Oct 5, 2018
| { | ||
| return s; | ||
| } | ||
| int j = 2; |
There was a problem hiding this comment.
Not a strict requirement but I find it to be a bad habit and generally dislike seeing one char variable names. when possible/(when you remember) please name variables something that makes sense to the context. j for example could be named "increment" and string could be named "name".
it's a small thing but it improves code readability a lot.
There was a problem hiding this comment.
Whether it's a bad habit, I don't know, but I tend to use bool b, String s, and int i, j and k.
Being aware that I work on a project with many contributors, I will of course try to apply to the coding style.
MrStevns
approved these changes
Oct 5, 2018
|
Thank you @davidlamhauge @candyface |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function added that suggest new filenames, that differ from existing ones.
If you want a new "Bitmap Layer" and a "Bitmap Layer" exists, it will suggest "Bitmap Layer 2" as filename, and so on.