Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when drawing after moving bitmap objects with select and move tools #385

Closed
ManuAros opened this issue Dec 21, 2015 · 2 comments
Closed
Labels

Comments

@ManuAros
Copy link

  1. Start fresh Pencil and draw something in frame 1
  2. use select tool to select the object you drew
  3. use move tool to move the object to a new location
  4. Add one frame
  5. Use pen tool to draw something in the new frame (2)
    and you will se that what you draw will be moved to about the same place
    as you moved the object in frame 1

Comment: same behaviour even if you start with making two frames.
Comment: I don't see this behaviour on vector only bitmap layers

Tested on 32 bit Windows 10, Pencil2D Dec 19 2015 Build.

@chchwy chchwy added the Bug label Dec 23, 2015
@feeef
Copy link
Contributor

feeef commented Dec 30, 2015

This is one of the main bugs of the current build. It is very annoying. jonasthomas from the forum said he would have a go fixing it.

I have implemented the current transform feature so I can help understand how that works.

  • The select tool is used to select
  • The move tool is used to handle the transformation of the selecton
  • The ScribbleArea handles the transformation at the BitmapImage / VectorImage level
  • For a bitmap image (the problem is here!) the transformation display is generated by the CanvasRenderer (called in ScribbleArea paintTransformedSelection()). This is just a temporary display. It must be applied or canceled (ScribbleArea applyTransformedSelection() / cancelTransformedSelection()).

If we go back painting or if we go to another frame without applying (deselect) or canceling (esc key) the transformation the CanvasRenderer doesn't "switch off" its transformation mode.

@ManuAros
Copy link
Author

ManuAros commented Jan 4, 2016

This can now be closed, tasaif fixed this issue.

@ManuAros ManuAros closed this as completed Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants