Update to WiX 5 #1827
Merged
Update to WiX 5 #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chchwy
force-pushed
the
wix-5
branch
3 times, most recently
from
e106ddc
to
98a073d
Compare
chchwy
approved these changes
May 19, 2024
chchwy
pushed a commit
that referenced
this pull request
May 22, 2024
* Work around WiX caching issue * Update to WiX 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the installer from WiX 4 to WiX 5, which came out earlier this month. WiX 5 moved the bootstrapper application (think of it as the UI) out-of-process, so the changes are a bit more extensive than usual but still pretty straightforward. Some packages and header files got renamed, initialisation moved to OnCreate and localisation loading moved to OnThemeLoaded. The window icon is made explicit since it is now created in a separate process and therefore no longer inherited from the main installer binary.
Additionally, I also added a small workaround for a WiX caching issue, which is unrelated to the version 5 update.
Already tested a bunch of different scenarios and haven’t seen any new issues pop up so far.