Fix fade in/out not working properly. #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s open The reason is that we didn't emit selection changes while moving, which meant that the opacity window would only have the fade in/out option available if you had frames selected before opening it.
When using fade in with initial opacity on 100% The result would look like: 1. 33% 2. 66% 3. 100% However I expected: 1. 0% 2. 50% 3. 100% Similar when using fade out with initial opacity of 100% 1. 100% 2. 66% 3. 33% I expected 1. 100% 2. 50% 3. 0%
… called Even though we might have updated other keyframes.
chchwy
force-pushed
the
layer-opacity-fixes
branch
from
fed31f7
to
8e5ff60
Compare
|
Confirmed the issue was fixed |
chchwy
pushed a commit
that referenced
this pull request
Jul 8, 2024
* Layer Opacity: Fix selection changes would not update while window was open The reason is that we didn't emit selection changes while moving, which meant that the opacity window would only have the fade in/out option available if you had frames selected before opening it. * Make none of the buttons in the dialog default enabled * Fix layer opacity fade in/out would not fade entirely When using fade in with initial opacity on 100% The result would look like: 1. 33% 2. 66% 3. 100% However I expected: 1. 0% 2. 50% 3. 100% Similar when using fade out with initial opacity of 100% 1. 100% 2. 66% 3. 33% I expected 1. 100% 2. 50% 3. 0% * Fix case where if the last frame was null, framesModified wouldn't be called Even though we might have updated other keyframes. * Apply small simplification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things I bumped into while writing release notes for 0.7.0, although I only found one thing I think is pretty fundamental, which is the fading mechanism that doesn't fade entirely. The rest are things that can be worked around.
if possible it would be nice to have them fixed before the release, since i'm hoping to mention the feature in our release post.
Fixes #1855