AnalyticsOptimizations: Fixes for code climate issues

pencilblue · Mar 1, 2016 · 12ffc5a · 12ffc5a
1 parent d54c5d5
commit 12ffc5a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/include/system/analytics_manager.js b/include/system/analytics_manager.js
@@ -116,11 +116,9 @@ module.exports = function AnalyticsManagerModule(pb) {
      * providers.
      */
     AnalyticsManager.prototype.gatherData = function(req, session, ls, cb) {
-        var site = this.site;
-        var timeout = this.timeout
 
         //retrieve keys and ensure there are providers to process
-        var providerKeys = AnalyticsManager.getKeys(site);
+        var providerKeys = AnalyticsManager.getKeys(this.site);
         if (providerKeys.length === 0) {
             return cb(null, DEFAULT_RESULT);
         }
@@ -151,7 +149,7 @@ module.exports = function AnalyticsManagerModule(pb) {
 
         return function(callback) {
             if (pb.log.isSilly()) {
-                pb.log.silly("AnalyticsManager: Rendering provider [%s] for URL [%s:%s]", keys[i], req.method, req.url);
+                pb.log.silly("AnalyticsManager: Rendering provider [%s] for URL [%s:%s]", key, req.method, req.url);
             }
 
             //build context object for builder functions to have access to params

diff --git a/plugins/ga/ga.js b/plugins/ga/ga.js
@@ -17,9 +17,6 @@
 
 module.exports = function (pb) {
 
-    //pb dependencies
-    var util = pb.util;
-
     /**
      * GoogleAnalytics - A sample for exemplifying what the main module file should
      * look like.