Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to resend password reset emails #1248

Open
dukeofsussex opened this issue Apr 11, 2017 · 1 comment
Open

Unable to resend password reset emails #1248

dukeofsussex opened this issue Apr 11, 2017 · 1 comment
Labels

Comments

@dukeofsussex
Copy link
Contributor

Description:
At https://github.com/pencilblue/pencilblue/blob/master/plugins/pencilblue/controllers/actions/admin/users/send_password_reset.js#L76 a check is being made using user_id, but the initial document is being added using userId (https://github.com/pencilblue/pencilblue/blob/master/plugins/pencilblue/controllers/actions/admin/users/send_password_reset.js#L83), causing the check to fail and a duplicate error to be thrown when trying to resend the password reset email, as a duplicate document is being inserted. The change is simple and I've confirmed it works, but here's the tricky part: Are you going with userId or user_id?

Steps to Reproduce:

  • Choose any user other than yourself
  • Click on "Reset password"
  • It should successfully send an email to the user
  • Click on "Reset password" again
  • Error

PencilBlue Version: 0.8

Node.js Version: 4.4.7

Environment Description: Win

@brianhyder
Copy link
Member

There was an issue close to this not too long ago. The goal was to update to userId and remove the underscore. Happy to merge a fix if you've got it

@brianhyder brianhyder added the bug label Apr 11, 2017
dukeofsussex added a commit to dukeofsussex/pencilblue that referenced this issue Apr 12, 2017
@dukeofsussex dukeofsussex mentioned this issue Apr 12, 2017
2 tasks
dukeofsussex added a commit to dukeofsussex/pencilblue that referenced this issue Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants